From 8fe4a2cb1ad3b4819e069179cc11430c5127613c Mon Sep 17 00:00:00 2001 From: Xisco Fauli Date: Tue, 29 Jun 2021 11:35:20 +0200 Subject: uitest: guard remaining execute_dialog_through_command Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ib8e7c5f5e2c9b8a7756fe533ea4f30349dd68761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118076 Tested-by: Xisco Fauli Reviewed-by: Xisco Fauli --- sfx2/qa/uitest/doc/objserv.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'sfx2/qa') diff --git a/sfx2/qa/uitest/doc/objserv.py b/sfx2/qa/uitest/doc/objserv.py index 7c658be8dfd8..67c4765d4840 100644 --- a/sfx2/qa/uitest/doc/objserv.py +++ b/sfx2/qa/uitest/doc/objserv.py @@ -14,14 +14,11 @@ class Test(UITestCase): def testPdfSigning(self): # Start Impress. with self.ui_test.load_file(get_url_for_data_file("pdf-sign.pdf")) as impress_doc: - doc = self.xUITest.getTopFocusWindow() # Now use File -> Digital signatures -> Digital signatures. - self.ui_test.execute_dialog_through_command(".uno:Signature") - xDialog = self.xUITest.getTopFocusWindow() - # Without the accompanying fix in place, this test would have failed with: - # uno.com.sun.star.uno.RuntimeException: Could not find child with id: close vcl/source/uitest/uiobject.cxx:452 - self.ui_test.close_dialog_through_button(xDialog.getChild("close")) - + with self.ui_test.execute_dialog_through_command_guarded(".uno:Signature", close_button="close"): + # Without the accompanying fix in place, this test would have failed with: + # uno.com.sun.star.uno.RuntimeException: Could not find child with id: close vcl/source/uitest/uiobject.cxx:452 + pass # vim: set shiftwidth=4 softtabstop=4 expandtab: -- cgit