From 366d08f2f6d4de922f6099c62bb81b49d89e0a68 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 8 Apr 2020 12:36:53 +0200 Subject: new loplugin:simplifypointertobool Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sfx2/source/dialog/filedlghelper.cxx | 2 +- sfx2/source/doc/objmisc.cxx | 2 +- sfx2/source/doc/sfxbasemodel.cxx | 2 +- sfx2/source/sidebar/SidebarController.cxx | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) (limited to 'sfx2') diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx index 7c4f73867d31..e39033880c0e 100644 --- a/sfx2/source/dialog/filedlghelper.cxx +++ b/sfx2/source/dialog/filedlghelper.cxx @@ -2395,7 +2395,7 @@ sal_Int16 FileDialogHelper::GetDialogType() const { return mpImpl ? mpImpl->m_nD bool FileDialogHelper::IsPasswordEnabled() const { - return mpImpl.get() && mpImpl->isPasswordEnabled(); + return mpImpl && mpImpl->isPasswordEnabled(); } OUString FileDialogHelper::GetRealFilter() const diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx index 86764e760ebe..3bb958246670 100644 --- a/sfx2/source/doc/objmisc.cxx +++ b/sfx2/source/doc/objmisc.cxx @@ -1439,7 +1439,7 @@ ErrCode SfxObjectShell::CallXScript( const Reference< XInterface >& _rxScriptCon { SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create(); ScopedVclPtr pScriptErrDlg( pFact->CreateScriptErrorDialog( aException ) ); - if ( pScriptErrDlg.get() ) + if ( pScriptErrDlg ) pScriptErrDlg->Execute(); } diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx index 36ec8cb7adc4..4cee94d0d95c 100644 --- a/sfx2/source/doc/sfxbasemodel.cxx +++ b/sfx2/source/doc/sfxbasemodel.cxx @@ -3919,7 +3919,7 @@ OUString SAL_CALL SfxBaseModel::getTitle() SfxModelGuard aGuard( *this ); OUString aResult = impl_getTitleHelper()->getTitle (); - if ( !m_pData->m_bExternalTitle && m_pData->m_pObjectShell.get() ) + if ( !m_pData->m_bExternalTitle && m_pData->m_pObjectShell ) { SfxMedium* pMedium = m_pData->m_pObjectShell->GetMedium(); if ( pMedium ) diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx index 5876c468d730..08606a83f9dc 100644 --- a/sfx2/source/sidebar/SidebarController.cxx +++ b/sfx2/source/sidebar/SidebarController.cxx @@ -1218,7 +1218,7 @@ IMPL_LINK(SidebarController, OnMenuItemSelected, Menu*, pMenu, bool) void SidebarController::RequestCloseDeck() { - if (comphelper::LibreOfficeKit::isActive() && mpCurrentDeck.get()) + if (comphelper::LibreOfficeKit::isActive() && mpCurrentDeck) { const vcl::ILibreOfficeKitNotifier* pNotifier = mpCurrentDeck->GetLOKNotifier(); auto pMobileNotifier = SfxViewShell::Current(); @@ -1243,7 +1243,7 @@ void SidebarController::RequestCloseDeck() mbIsDeckRequestedOpen = false; UpdateDeckOpenState(); - if (!mpCurrentDeck.get()) + if (!mpCurrentDeck) mpTabBar->RemoveDeckHighlight(); } -- cgit