From 4ff1f8153a3155303ea74f09cf4cb03d61e625a6 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 6 Jan 2021 18:23:37 +0100 Subject: Missing construction of SfxCmisVersionsDialog::m_xVersionBox MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit 29e36c699c610be4fe6f8a2fe21ae3e4c8bdbd38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108909 Reviewed-by: Caolán McNamara --- sfx2/source/dialog/versdlg.cxx | 1 + 1 file changed, 1 insertion(+) (limited to 'sfx2') diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx index 1901ce9b2c29..525325b72702 100644 --- a/sfx2/source/dialog/versdlg.cxx +++ b/sfx2/source/dialog/versdlg.cxx @@ -434,6 +434,7 @@ SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window* pParent, SfxViewFrame , m_xViewButton(m_xBuilder->weld_button("show")) , m_xDeleteButton(m_xBuilder->weld_button("delete")) , m_xCompareButton(m_xBuilder->weld_button("compare")) + , m_xVersionBox(m_xBuilder->weld_tree_view("versions")) { m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, m_xVersionBox->get_height_rows(15)); -- cgit