From 81055959e06848c917c4df1e4f19e1e5c6e70684 Mon Sep 17 00:00:00 2001 From: Mert Tumer Date: Fri, 6 Aug 2021 12:42:16 +0300 Subject: lok: Avoid redundant call to UpdateConfigurations We call doc_setView each time we send an event to LOK such as keystroke and SidebarController::notifyContextChange event is triggered after that UpdateConfigurations() call causes layout reallocating for whole sidebar and we end up keep doing it. It takes significant amount of cpu time for lok case for no reason. Signed-off-by: Mert Tumer Change-Id: I8f456156af841fdeaba1934498863a07a7d4554e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120112 Tested-by: Jenkins CollaboraOffice Reviewed-by: Michael Meeks (cherry picked from commit b606764ce2a042f2a38c98820d7236661149d20c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120138 Tested-by: Jenkins --- sfx2/source/sidebar/SidebarController.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sfx2') diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx index b81080c546cd..fff93887c3a7 100644 --- a/sfx2/source/sidebar/SidebarController.cxx +++ b/sfx2/source/sidebar/SidebarController.cxx @@ -355,7 +355,8 @@ void SAL_CALL SidebarController::notifyContextChangeEvent (const css::ui::Contex // calling with held // solarmutex // TODO: this call is redundant but mandatory for unit test to update context on document loading - UpdateConfigurations(); + if (!comphelper::LibreOfficeKit::isActive()) + UpdateConfigurations(); } } -- cgit