From 2d04d7cc559445d8c1559af6af6d981d9f682db4 Mon Sep 17 00:00:00 2001 From: Collabora Date: Thu, 15 Jul 2021 12:18:49 +0200 Subject: do not use "using namespace std" in headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's a bad style, doing that in headers can affect many source files (especially with PCH used). Change-Id: Ic9091a1d018e74606c9fa95df71a55faaa93d4ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119011 Tested-by: Jenkins Reviewed-by: Luboš Luňák --- shell/qa/zip/testzipimpl.cxx | 4 ++-- shell/qa/zip/testzipimpl.hxx | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'shell') diff --git a/shell/qa/zip/testzipimpl.cxx b/shell/qa/zip/testzipimpl.cxx index e669b6a8b40d..e39408f98496 100644 --- a/shell/qa/zip/testzipimpl.cxx +++ b/shell/qa/zip/testzipimpl.cxx @@ -48,8 +48,8 @@ TestZipImpl::~TestZipImpl() {} bool TestZipImpl::test_directory() { ZipFile::DirectoryPtr_t contents = zipFile.GetDirectory(); - vector& stringVector = *contents; - sort(stringVector.begin(), stringVector.end()); + std::vector& stringVector = *contents; + std::sort(stringVector.begin(), stringVector.end()); return expectedContents == stringVector; } diff --git a/shell/qa/zip/testzipimpl.hxx b/shell/qa/zip/testzipimpl.hxx index ae1ff8cedd72..cdea8b209549 100644 --- a/shell/qa/zip/testzipimpl.hxx +++ b/shell/qa/zip/testzipimpl.hxx @@ -26,13 +26,11 @@ #include #include -using namespace std; - class TestZipImpl { private: ZipFile zipFile; - vector expectedContents; + std::vector expectedContents; public: explicit TestZipImpl(StreamInterface* stream); -- cgit