From f3d9aab8410c00298f29ca0194c5d33d53c63ff2 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 5 May 2016 09:46:12 +0200 Subject: teach passstuffbyref plugin to check for.. unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist Tested-by: Jenkins Reviewed-by: Noel Grandin --- slideshow/source/engine/eventmultiplexer.cxx | 6 +++--- slideshow/source/engine/slide/userpaintoverlay.cxx | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'slideshow/source/engine') diff --git a/slideshow/source/engine/eventmultiplexer.cxx b/slideshow/source/engine/eventmultiplexer.cxx index b71e71c71e16..96b86bf2218d 100644 --- a/slideshow/source/engine/eventmultiplexer.cxx +++ b/slideshow/source/engine/eventmultiplexer.cxx @@ -1017,11 +1017,11 @@ void EventMultiplexer::notifySwitchEraserMode(){ } //adding erasing all ink features with UserPaintOverlay -void EventMultiplexer::notifyEraseAllInk( bool const& rEraseAllInk ) +void EventMultiplexer::notifyEraseAllInk( bool bEraseAllInk ) { mpImpl->maUserPaintEventHandlers.applyAll( - [&rEraseAllInk]( const UserPaintEventHandlerSharedPtr& pHandler ) - { return pHandler->eraseAllInkChanged( rEraseAllInk ); } ); + [&bEraseAllInk]( const UserPaintEventHandlerSharedPtr& pHandler ) + { return pHandler->eraseAllInkChanged( bEraseAllInk ); } ); } //adding erasing features with UserPaintOverlay diff --git a/slideshow/source/engine/slide/userpaintoverlay.cxx b/slideshow/source/engine/slide/userpaintoverlay.cxx index 68a3a4ea96a8..3e720c3b9322 100644 --- a/slideshow/source/engine/slide/userpaintoverlay.cxx +++ b/slideshow/source/engine/slide/userpaintoverlay.cxx @@ -161,9 +161,9 @@ namespace slideshow } } - bool eraseAllInkChanged( bool const& rEraseAllInk ) override + bool eraseAllInkChanged( bool bEraseAllInk ) override { - this->mbIsEraseAllModeActivated= rEraseAllInk; + this->mbIsEraseAllModeActivated = bEraseAllInk; // if the erase all mode is activated it will remove all ink from slide, // therefore destroy all the polygons stored if(mbIsEraseAllModeActivated) -- cgit