From d07c4fe7681d90f20c4c0dafefc3439e8265e734 Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Fri, 29 Oct 2021 10:06:09 +0300 Subject: Prepare for removal of non-const operator[] from Sequence in smoketest Change-Id: Ica192dfb16716b4fb38d59eee0a39c6dd411b6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124390 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- smoketest/smoketest.cxx | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'smoketest/smoketest.cxx') diff --git a/smoketest/smoketest.cxx b/smoketest/smoketest.cxx index a60f58167f66..80a29036f19b 100644 --- a/smoketest/smoketest.cxx +++ b/smoketest/smoketest.cxx @@ -140,15 +140,16 @@ void Test::test() { CPPUNIT_ASSERT( test::getTestArgument( u"smoketest.doc", &doc)); - css::uno::Sequence< css::beans::PropertyValue > args(2); - args[0].Name = "MacroExecutionMode"; - args[0].Handle = -1; - args[0].Value <<= css::document::MacroExecMode::ALWAYS_EXECUTE_NO_WARN; - args[0].State = css::beans::PropertyState_DIRECT_VALUE; - args[1].Name = "ReadOnly"; - args[1].Handle = -1; - args[1].Value <<= true; - args[1].State = css::beans::PropertyState_DIRECT_VALUE; + css::uno::Sequence< css::beans::PropertyValue > args{ + { /* Name */ "MacroExecutionMode", + /* Handle */ -1, + /* Value */ css::uno::Any(css::document::MacroExecMode::ALWAYS_EXECUTE_NO_WARN), + /* State */ css::beans::PropertyState_DIRECT_VALUE }, + { /* Name */ "ReadOnly", + /* Handle */ -1, + /* Value */ css::uno::Any(true), + /* State */ css::beans::PropertyState_DIRECT_VALUE } + }; css::util::URL url; url.Complete = "vnd.sun.star.script:Standard.Global.StartTestWithDefaultOptions?" "language=Basic&location=document"; -- cgit with FixedHyperlink? Change-Id: I00abe4bfa62a55c7b62ccd40e6c0294699317f26 Reviewed-on: https://gerrit.libreoffice.org/76897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> loplugin:passstuffbyref improved return in canvas and svtools 2017-12-26T06:16:07+00:00 Noel Grandin noel.grandin@collabora.co.uk 2017-12-25T17:21:12+00:00 c54d34f70819c5928fe30585e86d744eda4a254a and for now, ignore methods with params so we don't fall into the trap of thinking that calls to methods like: Bar& foo(Bar &p) { return p; } can be converted from Bar f() { return foo(Bar()); } to Bar const & f() { return foo(Bar()); } Change-Id: Ia3795eb2baf353cb6bec4ebf40451f2789d66ad7 Reviewed-on: https://gerrit.libreoffice.org/47034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 
and for now, ignore methods with params so we don't fall into the trap
of thinking that calls to methods like:
   Bar& foo(Bar &p) { return p; }
can be converted from
   Bar f() { return foo(Bar()); }
to
Bar const & f() { return foo(Bar()); }

Change-Id: Ia3795eb2baf353cb6bec4ebf40451f2789d66ad7
Reviewed-on: https://gerrit.libreoffice.org/47034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
loplugin:finalclasses in svtools 2017-10-24T08:54:23+00:00 Noel Grandin noel.grandin@collabora.co.uk 2017-10-24T06:06:22+00:00 f49b6d89fd9a903ce01a30bf9971188737ceda14 Change-Id: I596342a3d32e116ac5994b60a5bd8717d4f6a5dd Reviewed-on: https://gerrit.libreoffice.org/43733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 
Change-Id: I596342a3d32e116ac5994b60a5bd8717d4f6a5dd
Reviewed-on: https://gerrit.libreoffice.org/43733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
loplugin:constparams in svtools 2017-07-19T07:26:05+00:00 Noel Grandin noel.grandin@collabora.co.uk 2017-07-18T10:53:40+00:00 7b83ed313e0e54cb7da4525d13f63937e10867fa Change-Id: I2620419828864363af55011abe56143bb7d42f48 Reviewed-on: https://gerrit.libreoffice.org/40154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 
Change-Id: I2620419828864363af55011abe56143bb7d42f48
Reviewed-on: https://gerrit.libreoffice.org/40154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
tdf#82580 tools: rename Rectangle to tools::Rectangle 2017-03-31T06:27:11+00:00 Miklos Vajna vmiklos@collabora.co.uk 2017-03-30T18:27:55+00:00 a5a571307fb3306b74ab46b085cde6388270a770 Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> 
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
loplugin:countusersofdefaultparams in sot..svtools 2016-10-14T08:53:30+00:00 Noel Grandin noel.grandin@collabora.co.uk 2016-10-14T08:52:44+00:00 faf4bf0c3e017b9caec27a1f7355c9cf636bf19b Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14 
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
Remove _TYPED suffix from tools/link.hxx macros 2016-10-05T05:56:12+00:00 Stephan Bergmann sbergman@redhat.com 2016-10-05T05:56:12+00:00 106ea87205cfba1bc39dc99ad8c3ee5f8fe350fb ...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c 
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c