From bd44b3eef62f4325a189539d6ab1b90ca63cfc28 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 24 Apr 2019 13:40:59 +0200 Subject: tdf#89522 PERF FILEOPEN xlsx, part 1 Inherit from tools::WeakBase non-virtually, so that we can use a static_cast in tools::WeakReference::get instead of a dynamic_cast. This takes the file-open time from 1m21 to 40s for me. Add a clang plugin to make sure we don't accidentally end up inheriting from tools::WeakBase more than once. Change-Id: I9c7c36403333f99094e1f9d8cce2ecd9200377f9 Reviewed-on: https://gerrit.libreoffice.org/71231 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- solenv/CompilerTest_compilerplugins_clang.mk | 1 + 1 file changed, 1 insertion(+) (limited to 'solenv') diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index ff71625bc3a5..fbc2d8a8d452 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -79,6 +79,7 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/unusedvariablemore \ compilerplugins/clang/test/useuniqueptr \ compilerplugins/clang/test/vclwidgets \ + compilerplugins/clang/test/weakbase \ compilerplugins/clang/test/writeonlyvars \ )) -- cgit