From 1a3eedccd3f2c207b274e589c509975d3859f8f8 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 15 Jul 2015 20:26:40 +0100 Subject: cppcheck: noExplicitConstructor Change-Id: Ia86c6a2ce6c1f2501d0b18181966b61d9ef78746 --- stoc/source/security/access_controller.cxx | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) (limited to 'stoc/source/security/access_controller.cxx') diff --git a/stoc/source/security/access_controller.cxx b/stoc/source/security/access_controller.cxx index c59153ff6ee9..fd709b196896 100644 --- a/stoc/source/security/access_controller.cxx +++ b/stoc/source/security/access_controller.cxx @@ -188,8 +188,11 @@ class acc_Policy PermissionCollection m_permissions; public: - inline acc_Policy( - PermissionCollection const & permissions ); + explicit acc_Policy( + PermissionCollection const & permissions ) + : m_permissions( permissions ) + {} + virtual ~acc_Policy(); // XAccessControlContext impl @@ -198,11 +201,6 @@ public: throw (RuntimeException, std::exception) SAL_OVERRIDE; }; -inline acc_Policy::acc_Policy( - PermissionCollection const & permissions ) - : m_permissions( permissions ) -{} - acc_Policy::~acc_Policy() {} @@ -292,14 +290,12 @@ class cc_reset { void * m_cc; public: - inline cc_reset( void * cc ) + explicit cc_reset( void * cc ) : m_cc( cc ) {} inline ~cc_reset() { ::uno_setCurrentContext( m_cc, s_envType.pData, 0 ); } }; - - struct MutexHolder { Mutex m_mutex; @@ -343,7 +339,7 @@ protected: virtual void SAL_CALL disposing() SAL_OVERRIDE; public: - AccessController( Reference< XComponentContext > const & xComponentContext ); + explicit AccessController( Reference< XComponentContext > const & xComponentContext ); virtual ~AccessController(); // XInitialization impl -- cgit