From 789055bc2acb4c71483fd60ea258d158bd5aec10 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Apr 2016 16:39:03 +0200 Subject: clang-tidy performance-unnecessary-copy-initialization probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- stoc/source/typeconv/convert.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'stoc/source/typeconv/convert.cxx') diff --git a/stoc/source/typeconv/convert.cxx b/stoc/source/typeconv/convert.cxx index c595c17a4588..b0bfb0c4fc6a 100644 --- a/stoc/source/typeconv/convert.cxx +++ b/stoc/source/typeconv/convert.cxx @@ -486,7 +486,7 @@ double TypeConverter_Impl::toDouble( const Any& rAny, double min, double max ) Any SAL_CALL TypeConverter_Impl::convertTo( const Any& rVal, const Type& aDestType ) throw( IllegalArgumentException, CannotConvertException, RuntimeException, std::exception) { - Type aSourceType = rVal.getValueType(); + const Type& aSourceType = rVal.getValueType(); if (aSourceType == aDestType) return rVal; @@ -705,7 +705,7 @@ Any TypeConverter_Impl::convertToSimpleType( const Any& rVal, TypeClass aDestina Reference< XInterface >(), (sal_Int16) 1 ); } - Type aSourceType = rVal.getValueType(); + const Type& aSourceType = rVal.getValueType(); TypeClass aSourceClass = aSourceType.getTypeClass(); if (aDestinationClass == aSourceClass) return rVal; -- cgit