From e25669fcedcb7231254d3ba0e0224b2e3eb901d8 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 27 Oct 2015 12:52:16 +0200 Subject: don't allocate uno::Reference on the heap There is no point, since it's the size of a pointer anyway (found by temporarily making the new operator in uno::Reference deleted). Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34 Reviewed-on: https://gerrit.libreoffice.org/19603 Tested-by: Jenkins Reviewed-by: Noel Grandin --- stoc/source/javaloader/javaloader.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'stoc') diff --git a/stoc/source/javaloader/javaloader.cxx b/stoc/source/javaloader/javaloader.cxx index 3a454f16b5cb..7b80dbd492e7 100644 --- a/stoc/source/javaloader/javaloader.cxx +++ b/stoc/source/javaloader/javaloader.cxx @@ -372,15 +372,15 @@ css::uno::Reference SAL_CALL JavaComponentLoader_CreateInstance(cons MutexGuard guard( getInitMutex() ); // The javaloader is never destroyed and there can be only one! // Note that the first context wins .... - static css::uno::Reference< XInterface > *pStaticRef = 0; - if( pStaticRef ) + static css::uno::Reference< XInterface > xStaticRef; + if( xStaticRef.is() ) { - xRet = *pStaticRef; + xRet = xStaticRef; } else { xRet = *new JavaComponentLoader(xCtx); - pStaticRef = new css::uno::Reference< XInterface > ( xRet ); + xStaticRef = xRet; } } catch(const RuntimeException & runtimeException) { -- cgit