From 1f08bff31238d5818c54a0b86570689644dff087 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 14 May 2018 17:14:18 +0200 Subject: new loplugin:shouldreturnbool look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins Reviewed-by: Noel Grandin --- store/source/storbios.cxx | 3 +-- store/source/storbios.hxx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'store/source') diff --git a/store/source/storbios.cxx b/store/source/storbios.cxx index 1a34da60d420..fad48695797d 100644 --- a/store/source/storbios.cxx +++ b/store/source/storbios.cxx @@ -396,13 +396,12 @@ OStorePageBIOS::Ace::~Ace() m_prev->m_next = m_next; } -int +void SAL_CALL OStorePageBIOS::Ace::constructor ( void * obj, SAL_UNUSED_PARAMETER void * /* arg */) { Ace * ace = static_cast(obj); ace->m_next = ace->m_prev = ace; - return 1; } OStorePageBIOS::Ace * diff --git a/store/source/storbios.hxx b/store/source/storbios.hxx index 8c2abd54f5a7..fafb54e79fed 100644 --- a/store/source/storbios.hxx +++ b/store/source/storbios.hxx @@ -141,7 +141,7 @@ public: Ace(); ~Ace(); - static int SAL_CALL constructor (void * obj, void * arg); + static void SAL_CALL constructor (void * obj, void * arg); static Ace * find (Ace * head, sal_uInt32 addr); static void insert (Ace * head, Ace * entry); -- cgit