From 29bc12777ceffd00ed0ae103b8f2affa26897b4e Mon Sep 17 00:00:00 2001
From: Stephan Bergmann <sbergman@redhat.com>
Date: Sat, 15 Jan 2022 13:50:26 +0100
Subject: Let loplugin:nullptr look into template instantiations

It missed some occurrences of 0 when only looking into uninstantiated template
code, as Clang doesn't model them with an ImplicitCastExpr, even if the target
is known to be a (dependent) pointer type.

Looking into all template instantiations of course carries the risk that a given
use of 0 is meant to be interpreted as a pointer in some and as an integer in
other instantiations.  But the only case where that happened in the current code
base is RegistryValueList::getElement (include/registry/registry.hxx), where {}
is arguably a better choice anyway.  (And which would presumably also hold for
any future such cases.)

Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
---
 store/source/storbase.hxx | 6 +++---
 store/source/store.cxx    | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'store')

diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx
index f4745d7c6885..20f6f3245638 100644
--- a/store/source/storbase.hxx
+++ b/store/source/storbase.hxx
@@ -290,7 +290,7 @@ struct PageData
             {
                 return new(page) T(nSize);
             }
-            return 0;
+            return nullptr;
         }
 
         bool allocate (void ** ppPage, sal_uInt16 * pnSize)
@@ -406,13 +406,13 @@ class PageHolderObject
     template< class U >
     static U * dynamic_page_cast (PageData * p)
     {
-        return isA<U>(p) ? static_cast<U*>(p) : 0;
+        return isA<U>(p) ? static_cast<U*>(p) : nullptr;
     }
 
     template< class U >
     static U const * dynamic_page_cast (PageData const * p)
     {
-        return isA<U>(p) ? static_cast<U const *>(p) : 0;
+        return isA<U>(p) ? static_cast<U const *>(p) : nullptr;
     }
 
 public:
diff --git a/store/source/store.cxx b/store/source/store.cxx
index dfd41571e2dd..566efda73769 100644
--- a/store/source/store.cxx
+++ b/store/source/store.cxx
@@ -52,7 +52,7 @@ public:
     {
         return store::query (
             static_cast<OStoreObject*>(pHandle),
-            static_cast<store_handle_type*>(0));
+            static_cast<store_handle_type*>(nullptr));
     }
 };
 
-- 
cgit