From 7d8196ea2f4ec3634dbad7367345e62c4ea9893d Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Thu, 22 Sep 2016 22:20:48 +0200 Subject: perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related There were over 150 places in *::Notify() functions that did some dynamic_cast of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke Tested-by: Eike Rathke --- svl/source/notify/SfxBroadcaster.cxx | 4 ++-- svl/source/notify/broadcast.cxx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'svl/source/notify') diff --git a/svl/source/notify/SfxBroadcaster.cxx b/svl/source/notify/SfxBroadcaster.cxx index eaeed4dbee49..3b069b1989fc 100644 --- a/svl/source/notify/SfxBroadcaster.cxx +++ b/svl/source/notify/SfxBroadcaster.cxx @@ -20,7 +20,7 @@ #include #include -#include +#include #include #include @@ -55,7 +55,7 @@ void SfxBroadcaster::Broadcast( const SfxHint &rHint ) SfxBroadcaster::~SfxBroadcaster() { - Broadcast( SfxSimpleHint(SFX_HINT_DYING) ); + Broadcast( SfxHint(SFX_HINT_DYING) ); // remove all still registered listeners for (size_t i = 0; i < mpImpl->m_Listeners.size(); ++i) diff --git a/svl/source/notify/broadcast.cxx b/svl/source/notify/broadcast.cxx index 2a9338ca787e..cd110e19e66e 100644 --- a/svl/source/notify/broadcast.cxx +++ b/svl/source/notify/broadcast.cxx @@ -19,7 +19,7 @@ #include #include -#include +#include #include void SvtBroadcaster::Normalize() const @@ -101,7 +101,7 @@ SvtBroadcaster::SvtBroadcaster( const SvtBroadcaster &rBC ) : SvtBroadcaster::~SvtBroadcaster() { mbDisposing = true; - Broadcast( SfxSimpleHint(SFX_HINT_DYING) ); + Broadcast( SfxHint(SFX_HINT_DYING) ); Normalize(); -- cgit