From 0f71828a9582f241dcddac5fe9a11fdf3a1a4e1c Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Mon, 8 Jun 2015 09:29:35 +0100 Subject: cppcheck: noExplicitConstructor Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf --- svl/source/items/style.cxx | 6 +++--- svl/source/misc/sharedstringpool.cxx | 2 +- svl/source/numbers/numuno.cxx | 2 +- svl/source/numbers/supservs.hxx | 2 +- svl/source/numbers/zforfind.hxx | 2 +- svl/source/numbers/zforscan.hxx | 2 +- svl/source/passwordcontainer/syscreds.hxx | 2 +- svl/source/svdde/ddesvr.cxx | 2 +- svl/source/undo/undo.cxx | 10 +++++----- 9 files changed, 15 insertions(+), 15 deletions(-) (limited to 'svl/source') diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx index bbbd45ede5e2..a9a9ce3ce7c5 100644 --- a/svl/source/items/style.cxx +++ b/svl/source/items/style.cxx @@ -385,7 +385,7 @@ namespace { struct DoesStyleMatchStyleSheetPredicate SAL_FINAL : public svl::StyleSheetPredicate { - DoesStyleMatchStyleSheetPredicate(SfxStyleSheetIterator *it) + explicit DoesStyleMatchStyleSheetPredicate(SfxStyleSheetIterator *it) : mIterator(it) {;} bool @@ -717,7 +717,7 @@ SfxStyleSheetBasePool& SfxStyleSheetBasePool::operator=( const SfxStyleSheetBase namespace { struct AddStyleSheetCallback : svl::StyleSheetCallback { - AddStyleSheetCallback(SfxStyleSheetBasePool *pool) + explicit AddStyleSheetCallback(SfxStyleSheetBasePool *pool) : mPool(pool) {;} void DoIt(const SfxStyleSheetBase& ssheet) SAL_OVERRIDE @@ -820,7 +820,7 @@ namespace struct StyleSheetDisposerFunctor SAL_FINAL : public svl::StyleSheetDisposer { - StyleSheetDisposerFunctor(SfxStyleSheetBasePool* pool) + explicit StyleSheetDisposerFunctor(SfxStyleSheetBasePool* pool) : mPool(pool) {;} void diff --git a/svl/source/misc/sharedstringpool.cxx b/svl/source/misc/sharedstringpool.cxx index e1dfe94453fd..bb9be8c7b7eb 100644 --- a/svl/source/misc/sharedstringpool.cxx +++ b/svl/source/misc/sharedstringpool.cxx @@ -57,7 +57,7 @@ struct SharedStringPool::Impl StrStoreType maStrStore; const CharClass* mpCharClass; - Impl( const CharClass* pCharClass ) : mpCharClass(pCharClass) {} + explicit Impl( const CharClass* pCharClass ) : mpCharClass(pCharClass) {} }; SharedStringPool::SharedStringPool( const CharClass* pCharClass ) : diff --git a/svl/source/numbers/numuno.cxx b/svl/source/numbers/numuno.cxx index efcdc2af0bb2..4bfb4a4282b4 100644 --- a/svl/source/numbers/numuno.cxx +++ b/svl/source/numbers/numuno.cxx @@ -33,7 +33,7 @@ public: SvNumberFormatter* pFormatter; mutable ::comphelper::SharedMutex aMutex; - SvNumFmtSuppl_Impl(SvNumberFormatter* p) : + explicit SvNumFmtSuppl_Impl(SvNumberFormatter* p) : pFormatter(p) {} }; diff --git a/svl/source/numbers/supservs.hxx b/svl/source/numbers/supservs.hxx index da04e95e1e70..9051abbb7e58 100644 --- a/svl/source/numbers/supservs.hxx +++ b/svl/source/numbers/supservs.hxx @@ -43,7 +43,7 @@ protected: m_xORB; public: - SvNumberFormatsSupplierServiceObject(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); + explicit SvNumberFormatsSupplierServiceObject(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); virtual ~SvNumberFormatsSupplierServiceObject(); // XInterface diff --git a/svl/source/numbers/zforfind.hxx b/svl/source/numbers/zforfind.hxx index c9f260a37c42..3e34b50b9a0a 100644 --- a/svl/source/numbers/zforfind.hxx +++ b/svl/source/numbers/zforfind.hxx @@ -32,7 +32,7 @@ class SvNumberFormatter; class ImpSvNumberInputScan { public: - ImpSvNumberInputScan( SvNumberFormatter* pFormatter ); + explicit ImpSvNumberInputScan( SvNumberFormatter* pFormatter ); ~ImpSvNumberInputScan(); /*!*/ void ChangeIntl(); // MUST be called if language changes diff --git a/svl/source/numbers/zforscan.hxx b/svl/source/numbers/zforscan.hxx index 03d5efa5db33..9e8816b8c628 100644 --- a/svl/source/numbers/zforscan.hxx +++ b/svl/source/numbers/zforscan.hxx @@ -40,7 +40,7 @@ class ImpSvNumberformatScan { public: - ImpSvNumberformatScan( SvNumberFormatter* pFormatter ); + explicit ImpSvNumberformatScan( SvNumberFormatter* pFormatter ); ~ImpSvNumberformatScan(); void ChangeIntl(); // Replaces Keywords diff --git a/svl/source/passwordcontainer/syscreds.hxx b/svl/source/passwordcontainer/syscreds.hxx index 45574dae96af..f21744cccd6b 100644 --- a/svl/source/passwordcontainer/syscreds.hxx +++ b/svl/source/passwordcontainer/syscreds.hxx @@ -32,7 +32,7 @@ class SysCredentialsConfig; class SysCredentialsConfigItem : public utl::ConfigItem { public: - SysCredentialsConfigItem( SysCredentialsConfig * pOwner ); + explicit SysCredentialsConfigItem( SysCredentialsConfig * pOwner ); //virtual ~SysCredentialsConfigItem(); virtual void Notify( diff --git a/svl/source/svdde/ddesvr.cxx b/svl/source/svdde/ddesvr.cxx index 923222b7b9a1..b5a9960f00bf 100644 --- a/svl/source/svdde/ddesvr.cxx +++ b/svl/source/svdde/ddesvr.cxx @@ -39,7 +39,7 @@ struct DdeItemImpData sal_uLong nHCnv; sal_uInt16 nCnt; - DdeItemImpData( sal_uLong nH ) : nHCnv( nH ), nCnt( 1 ) {} + expliit DdeItemImpData( sal_uLong nH ) : nHCnv( nH ), nCnt( 1 ) {} }; class DdeItemImp { diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx index 0d967f86f24e..a6f75bf02085 100644 --- a/svl/source/undo/undo.cxx +++ b/svl/source/undo/undo.cxx @@ -150,7 +150,7 @@ struct MarkedUndoAction SfxUndoAction* pAction; ::std::vector< UndoStackMark > aMarks; - MarkedUndoAction( SfxUndoAction* i_action ) + explicit MarkedUndoAction( SfxUndoAction* i_action ) :pAction( i_action ) ,aMarks() { @@ -239,7 +239,7 @@ struct SVL_DLLPRIVATE SfxUndoManager_Data UndoListeners aListeners; - SfxUndoManager_Data( size_t i_nMaxUndoActionCount ) + explicit SfxUndoManager_Data( size_t i_nMaxUndoActionCount ) :pUndoArray( new SfxUndoArray( i_nMaxUndoActionCount ) ) ,pActUndoArray( NULL ) ,pFatherUndoArray( NULL ) @@ -264,7 +264,7 @@ namespace svl { namespace undo { namespace impl class SVL_DLLPRIVATE LockGuard { public: - LockGuard( SfxUndoManager& i_manager ) + explicit LockGuard( SfxUndoManager& i_manager ) :m_manager( i_manager ) { m_manager.ImplEnableUndo_Lock( false ); @@ -284,7 +284,7 @@ namespace svl { namespace undo { namespace impl struct SVL_DLLPRIVATE NotifyUndoListener : public ::std::unary_function< SfxUndoListener*, void > { - NotifyUndoListener( UndoListenerVoidMethod i_notificationMethod ) + explicit NotifyUndoListener( UndoListenerVoidMethod i_notificationMethod ) :m_notificationMethod( i_notificationMethod ) ,m_altNotificationMethod( NULL ) ,m_sActionComment() @@ -325,7 +325,7 @@ namespace svl { namespace undo { namespace impl class SVL_DLLPRIVATE UndoManagerGuard { public: - UndoManagerGuard( SfxUndoManager_Data& i_managerData ) + explicit UndoManagerGuard( SfxUndoManager_Data& i_managerData ) :m_rManagerData( i_managerData ) ,m_aGuard( i_managerData.aMutex ) ,m_notifiers() -- cgit