From 165d0a149d631d96a91118dfc7686bd2ebb0b6b9 Mon Sep 17 00:00:00 2001 From: Jochen Nitschke Date: Sat, 30 Sep 2017 23:58:17 +0200 Subject: clang-tidy modernize-use-equals-default in svl SfxPoolItem has a copy constructor and its copy assignment operator is deleted. Derived classes have a implicit defined copy constructor too, if all members are copy constructible. This patch removes default able copy constructors on such items. Note: clang-tidy only finds functions defined in source, inlined functions in headers are picked manualy. Change-Id: I7e642a2ecf139420c53f6fcb39208918dd1a8d52 Reviewed-on: https://gerrit.libreoffice.org/43003 Tested-by: Jenkins Reviewed-by: Noel Grandin --- svl/source/items/flagitem.cxx | 7 ------- svl/source/items/ilstitem.cxx | 6 ------ svl/source/items/imageitm.cxx | 2 +- svl/source/items/int64item.cxx | 5 ----- svl/source/items/intitem.cxx | 5 ----- svl/source/items/lckbitem.cxx | 7 ------- svl/source/items/poolitem.cxx | 6 ------ svl/source/items/ptitem.cxx | 7 ------- svl/source/items/rectitem.cxx | 7 ------- svl/source/items/rngitem.cxx | 8 -------- svl/source/items/sitem.cxx | 2 +- svl/source/items/slstitm.cxx | 8 -------- 12 files changed, 2 insertions(+), 68 deletions(-) (limited to 'svl/source') diff --git a/svl/source/items/flagitem.cxx b/svl/source/items/flagitem.cxx index 916c94ef961b..6c4f41abb586 100644 --- a/svl/source/items/flagitem.cxx +++ b/svl/source/items/flagitem.cxx @@ -30,13 +30,6 @@ SfxFlagItem::SfxFlagItem( sal_uInt16 nW, sal_uInt16 nV ) : } -SfxFlagItem::SfxFlagItem( const SfxFlagItem& rItem ) : - SfxPoolItem( rItem ), - nVal( rItem.nVal ) -{ -} - - SvStream& SfxFlagItem::Store(SvStream &rStream, sal_uInt16) const { rStream.WriteUInt16( nVal ); diff --git a/svl/source/items/ilstitem.cxx b/svl/source/items/ilstitem.cxx index c020901e583b..bf95e3afd52f 100644 --- a/svl/source/items/ilstitem.cxx +++ b/svl/source/items/ilstitem.cxx @@ -46,12 +46,6 @@ SfxIntegerListItem::SfxIntegerListItem( sal_uInt16 which, const css::uno::Sequen m_aList[n] = rList[n]; } -SfxIntegerListItem::SfxIntegerListItem( const SfxIntegerListItem& rItem ) - : SfxPoolItem( rItem ) - , m_aList( rItem.m_aList ) -{ -} - SfxIntegerListItem::~SfxIntegerListItem() { } diff --git a/svl/source/items/imageitm.cxx b/svl/source/items/imageitm.cxx index a77f52f8b2fa..269e80936af3 100644 --- a/svl/source/items/imageitm.cxx +++ b/svl/source/items/imageitm.cxx @@ -44,7 +44,7 @@ SfxImageItem::SfxImageItem( sal_uInt16 which ) SfxImageItem::SfxImageItem( const SfxImageItem& rItem ) : SfxInt16Item( rItem ), - pImpl( new SfxImageItem_Impl( *(rItem.pImpl.get()) ) ) + pImpl( new SfxImageItem_Impl( *rItem.pImpl ) ) { } diff --git a/svl/source/items/int64item.cxx b/svl/source/items/int64item.cxx index afe284520bb8..b5dc818b9d46 100644 --- a/svl/source/items/int64item.cxx +++ b/svl/source/items/int64item.cxx @@ -21,11 +21,6 @@ SfxInt64Item::SfxInt64Item( sal_uInt16 nWhich, SvStream& rStream ) : rStream.ReadInt64(mnValue); } -SfxInt64Item::SfxInt64Item( const SfxInt64Item& rItem ) : - SfxPoolItem(rItem), mnValue(rItem.mnValue) -{ -} - SfxInt64Item::~SfxInt64Item() {} bool SfxInt64Item::operator== ( const SfxPoolItem& rItem ) const diff --git a/svl/source/items/intitem.cxx b/svl/source/items/intitem.cxx index 6fdd060a9676..37d07926e2bf 100644 --- a/svl/source/items/intitem.cxx +++ b/svl/source/items/intitem.cxx @@ -153,11 +153,6 @@ SfxMetricItem::SfxMetricItem(sal_uInt16 which, sal_uInt32 nValue): { } -SfxMetricItem::SfxMetricItem(const SfxMetricItem & rItem): - SfxInt32Item(rItem) -{ -} - // virtual void SfxMetricItem::ScaleMetrics(long nMult, long nDiv) { diff --git a/svl/source/items/lckbitem.cxx b/svl/source/items/lckbitem.cxx index a3f89de4c339..4d47efa937e2 100644 --- a/svl/source/items/lckbitem.cxx +++ b/svl/source/items/lckbitem.cxx @@ -44,13 +44,6 @@ SfxLockBytesItem::SfxLockBytesItem( sal_uInt16 nW, SvStream &rStream ) } -SfxLockBytesItem::SfxLockBytesItem( const SfxLockBytesItem& rItem ) -: SfxPoolItem( rItem ), - _xVal( rItem._xVal ) -{ -} - - SfxLockBytesItem::~SfxLockBytesItem() { } diff --git a/svl/source/items/poolitem.cxx b/svl/source/items/poolitem.cxx index aebe8cda4389..5fe5c480ff07 100644 --- a/svl/source/items/poolitem.cxx +++ b/svl/source/items/poolitem.cxx @@ -149,12 +149,6 @@ SfxVoidItem::SfxVoidItem( sal_uInt16 which ): { } -SfxVoidItem::SfxVoidItem( const SfxVoidItem& rCopy): - SfxPoolItem(rCopy) -{ -} - - bool SfxVoidItem::operator==( const SfxPoolItem& rCmp ) const { assert(SfxPoolItem::operator==(rCmp)); diff --git a/svl/source/items/ptitem.cxx b/svl/source/items/ptitem.cxx index dd6f3a6bd3bb..03493d143e04 100644 --- a/svl/source/items/ptitem.cxx +++ b/svl/source/items/ptitem.cxx @@ -46,13 +46,6 @@ SfxPointItem::SfxPointItem( sal_uInt16 nW, const Point& rVal ) : } -SfxPointItem::SfxPointItem( const SfxPointItem& rItem ) : - SfxPoolItem( rItem ), - aVal( rItem.aVal ) -{ -} - - bool SfxPointItem::GetPresentation ( SfxItemPresentation /*ePresentation*/, diff --git a/svl/source/items/rectitem.cxx b/svl/source/items/rectitem.cxx index e4bd0d9b97c2..d481a78df22d 100644 --- a/svl/source/items/rectitem.cxx +++ b/svl/source/items/rectitem.cxx @@ -43,13 +43,6 @@ SfxRectangleItem::SfxRectangleItem( sal_uInt16 nW, const tools::Rectangle& rVal } -SfxRectangleItem::SfxRectangleItem( const SfxRectangleItem& rItem ) : - SfxPoolItem( rItem ), - aVal( rItem.aVal ) -{ -} - - bool SfxRectangleItem::GetPresentation ( SfxItemPresentation /*ePresentation*/, diff --git a/svl/source/items/rngitem.cxx b/svl/source/items/rngitem.cxx index efb837eaab98..6b0a3768d555 100644 --- a/svl/source/items/rngitem.cxx +++ b/svl/source/items/rngitem.cxx @@ -32,14 +32,6 @@ SfxRangeItem::SfxRangeItem( sal_uInt16 which, sal_uInt16 from, sal_uInt16 to ): } -SfxRangeItem::SfxRangeItem( const SfxRangeItem& rItem ) : - SfxPoolItem( rItem ) -{ - nFrom = rItem.nFrom; - nTo = rItem.nTo; -} - - bool SfxRangeItem::GetPresentation ( SfxItemPresentation /*ePresentation*/, diff --git a/svl/source/items/sitem.cxx b/svl/source/items/sitem.cxx index ef50cc1a9037..7b9264910597 100644 --- a/svl/source/items/sitem.cxx +++ b/svl/source/items/sitem.cxx @@ -42,7 +42,7 @@ SfxSetItem::SfxSetItem( sal_uInt16 which, std::unique_ptr &&pS) : SfxSetItem::SfxSetItem( const SfxSetItem& rCopy, SfxItemPool *pPool ) : - SfxPoolItem(rCopy.Which()), + SfxPoolItem(rCopy), pSet(rCopy.pSet->Clone(true, pPool)) { } diff --git a/svl/source/items/slstitm.cxx b/svl/source/items/slstitm.cxx index 4a5e40595530..a0acd09fc532 100644 --- a/svl/source/items/slstitm.cxx +++ b/svl/source/items/slstitm.cxx @@ -64,14 +64,6 @@ SfxStringListItem::SfxStringListItem( sal_uInt16 which, SvStream& rStream ) : } } - -SfxStringListItem::SfxStringListItem( const SfxStringListItem& rItem ) : - SfxPoolItem( rItem ), - mpList(rItem.mpList) -{ -} - - SfxStringListItem::~SfxStringListItem() { } -- cgit