From 14cd5182c5f64c43581c82db8c958369152226ac Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 10 May 2016 16:42:16 +0200 Subject: Replace fallthrough comments with new SAL_FALLTHROUGH macro ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca --- svtools/source/control/valueset.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'svtools/source/control/valueset.cxx') diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx index f827dbfa2264..b2f58c2b0832 100644 --- a/svtools/source/control/valueset.cxx +++ b/svtools/source/control/valueset.cxx @@ -1336,7 +1336,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent ) return; } nVStep *= mnVisLines; - // intentional fall-through + SAL_FALLTHROUGH; case KEY_UP: if (nCurPos != VALUESET_ITEM_NONEITEM) { @@ -1373,7 +1373,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent ) return; } nVStep *= mnVisLines; - // intentional fall-through + SAL_FALLTHROUGH; case KEY_DOWN: if (nCurPos != nLastItem) { @@ -1398,7 +1398,7 @@ void ValueSet::KeyInput( const KeyEvent& rKeyEvent ) Select(); break; } - // intentional fall-through + SAL_FALLTHROUGH; default: Control::KeyInput( rKeyEvent ); return; -- cgit