From 2962ceec4b96758bec7e7a0390d5ec60e3ce708f Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed, 10 May 2017 12:37:04 +0200
Subject: remove some unnecessary temporary OUStrings

found with:
git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return

Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02
Reviewed-on: https://gerrit.libreoffice.org/37463
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 svtools/source/config/miscopt.cxx | 32 +++++++++++++-------------------
 svtools/source/svhtml/parhtml.cxx |  2 +-
 2 files changed, 14 insertions(+), 20 deletions(-)

(limited to 'svtools/source')

diff --git a/svtools/source/config/miscopt.cxx b/svtools/source/config/miscopt.cxx
index 4d63b6669024..fa53cf0d2208 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -715,27 +715,21 @@ void SvtMiscOptions_Impl::ImplCommit()
 
 Sequence< OUString > SvtMiscOptions_Impl::GetPropertyNames()
 {
-    // Build list of configuration key names.
-    const OUString pProperties[] =
+    return Sequence<OUString>
     {
-        OUString(PROPERTYNAME_PLUGINSENABLED),
-        OUString(PROPERTYNAME_SYMBOLSET),
-        OUString(PROPERTYNAME_TOOLBOXSTYLE),
-        OUString(PROPERTYNAME_USESYSTEMFILEDIALOG),
-        OUString(PROPERTYNAME_ICONTHEME),
-        OUString(PROPERTYNAME_USESYSTEMPRINTDIALOG),
-        OUString(PROPERTYNAME_SHOWLINKWARNINGDIALOG),
-        OUString(PROPERTYNAME_DISABLEUICUSTOMIZATION),
-        OUString(PROPERTYNAME_EXPERIMENTALMODE),
-        OUString(PROPERTYNAME_MACRORECORDERMODE),
-        OUString(PROPERTYNAME_SIDEBARICONSIZE),
-        OUString(PROPERTYNAME_NOTEBOOKBARICONSIZE)
+        PROPERTYNAME_PLUGINSENABLED,
+        PROPERTYNAME_SYMBOLSET,
+        PROPERTYNAME_TOOLBOXSTYLE,
+        PROPERTYNAME_USESYSTEMFILEDIALOG,
+        PROPERTYNAME_ICONTHEME,
+        PROPERTYNAME_USESYSTEMPRINTDIALOG,
+        PROPERTYNAME_SHOWLINKWARNINGDIALOG,
+        PROPERTYNAME_DISABLEUICUSTOMIZATION,
+        PROPERTYNAME_EXPERIMENTALMODE,
+        PROPERTYNAME_MACRORECORDERMODE,
+        PROPERTYNAME_SIDEBARICONSIZE,
+        PROPERTYNAME_NOTEBOOKBARICONSIZE
     };
-
-    // Initialize return sequence with these list ...
-    const Sequence< OUString > seqPropertyNames( pProperties, SAL_N_ELEMENTS( pProperties ) );
-    // ... and return it.
-    return seqPropertyNames;
 }
 
 namespace {
diff --git a/svtools/source/svhtml/parhtml.cxx b/svtools/source/svhtml/parhtml.cxx
index e1189e451af5..d4da3e7a0fa2 100644
--- a/svtools/source/svhtml/parhtml.cxx
+++ b/svtools/source/svhtml/parhtml.cxx
@@ -2011,7 +2011,7 @@ bool HTMLParser::ParseMetaOptionsImpl(
                     try {
                         xUDProps->addProperty(aName,
                             beans::PropertyAttribute::REMOVABLE,
-                            uno::makeAny(OUString(aContent)));
+                            uno::makeAny(aContent));
                         AddMetaUserDefined(aName);
                         bChanged = true;
                     } catch (uno::Exception &) {
-- 
cgit