From 508c95f1b655d9cfa6be37a5a9de9aff6fd383bf Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel@peralex.com>
Date: Mon, 18 Jul 2016 09:22:27 +0200
Subject: improve passstuffbyref return analysis

Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
---
 svtools/source/config/menuoptions.cxx | 4 ++--
 svtools/source/control/fmtfield.cxx   | 2 +-
 svtools/source/control/valueacc.cxx   | 2 +-
 svtools/source/control/valueimp.hxx   | 2 +-
 svtools/source/misc/sampletext.cxx    | 8 ++++----
 5 files changed, 9 insertions(+), 9 deletions(-)

(limited to 'svtools')

diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx
index c0fcaefb0491..d947d6ca6dd3 100644
--- a/svtools/source/config/menuoptions.cxx
+++ b/svtools/source/config/menuoptions.cxx
@@ -125,7 +125,7 @@ class SvtMenuOptions_Impl : public ConfigItem
             @return     A list of needed configuration keys is returned.
         *//*-*****************************************************************************************************/
 
-        static Sequence< OUString > impl_GetPropertyNames();
+        static Sequence< OUString > const & impl_GetPropertyNames();
 };
 
 //  constructor
@@ -299,7 +299,7 @@ void SvtMenuOptions_Impl::ImplCommit()
 
 //  private method
 
-Sequence< OUString > SvtMenuOptions_Impl::impl_GetPropertyNames()
+Sequence< OUString > const & SvtMenuOptions_Impl::impl_GetPropertyNames()
 {
     // Build static list of configuration key names.
     static const OUString pProperties[] =
diff --git a/svtools/source/control/fmtfield.cxx b/svtools/source/control/fmtfield.cxx
index b92e52d171dc..deb22cda6b9b 100644
--- a/svtools/source/control/fmtfield.cxx
+++ b/svtools/source/control/fmtfield.cxx
@@ -405,7 +405,7 @@ void FormattedField::SetTextFormatted(const OUString& rStr)
     m_ValueState = valueString;
 }
 
-OUString FormattedField::GetTextValue() const
+OUString const & FormattedField::GetTextValue() const
 {
     if (m_ValueState != valueString )
     {
diff --git a/svtools/source/control/valueacc.cxx b/svtools/source/control/valueacc.cxx
index 38628ea7e14f..28e849c0f490 100644
--- a/svtools/source/control/valueacc.cxx
+++ b/svtools/source/control/valueacc.cxx
@@ -52,7 +52,7 @@ ValueSetItem::~ValueSetItem()
 }
 
 
-uno::Reference< accessibility::XAccessible > ValueSetItem::GetAccessible( bool bIsTransientChildrenDisabled )
+uno::Reference< accessibility::XAccessible > const & ValueSetItem::GetAccessible( bool bIsTransientChildrenDisabled )
 {
     if( !mxAcc.is() )
         mxAcc = new ValueItemAcc( this, bIsTransientChildrenDisabled );
diff --git a/svtools/source/control/valueimp.hxx b/svtools/source/control/valueimp.hxx
index c3d2339181de..53b13a05b38e 100644
--- a/svtools/source/control/valueimp.hxx
+++ b/svtools/source/control/valueimp.hxx
@@ -64,7 +64,7 @@ struct ValueSetItem
     explicit ValueSetItem( ValueSet& rParent );
     ~ValueSetItem();
 
-    css::uno::Reference< css::accessibility::XAccessible >
+    css::uno::Reference< css::accessibility::XAccessible > const &
                         GetAccessible( bool bIsTransientChildrenDisabled );
 };
 
diff --git a/svtools/source/misc/sampletext.cxx b/svtools/source/misc/sampletext.cxx
index 59bee404c571..2cbb18345073 100644
--- a/svtools/source/misc/sampletext.cxx
+++ b/svtools/source/misc/sampletext.cxx
@@ -1107,28 +1107,28 @@ namespace
     }
 
     //false for all bits considered "Latin" by LibreOffice
-    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> getLatinMask()
+    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> const & getLatinMask()
     {
         static std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> s_Mask(getMaskByScriptType(css::i18n::ScriptType::LATIN));
         return s_Mask;
     }
 
     //false for all bits considered "Asian" by LibreOffice
-    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> getCJKMask()
+    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> const & getCJKMask()
     {
         static std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> s_Mask(getMaskByScriptType(css::i18n::ScriptType::ASIAN));
         return s_Mask;
     }
 
     //false for all bits considered "Complex" by LibreOffice
-    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> getCTLMask()
+    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> const & getCTLMask()
     {
         static std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> s_Mask(getMaskByScriptType(css::i18n::ScriptType::COMPLEX));
         return s_Mask;
     }
 
     //false for all bits considered "WEAK" by LibreOffice
-    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> getWeakMask()
+    std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> const & getWeakMask()
     {
         static std::bitset<vcl::UnicodeCoverage::MAX_UC_ENUM> s_Mask(getMaskByScriptType(css::i18n::ScriptType::WEAK));
         return s_Mask;
-- 
cgit