From b4844c310bd9897fef59e8a4da0513100ea86096 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 13 Oct 2023 08:44:49 +0200 Subject: Repurpose loplugin:stringstatic for O[U]String vars that can be constexpr ...now that warning about O[U]String vars that could be O[U]StringLiteral is no longer useful Change-Id: I389e72038171f28482049b41f6224257dd11f452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157992 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- svx/qa/unit/gallery/test_gallery.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'svx/qa/unit') diff --git a/svx/qa/unit/gallery/test_gallery.cxx b/svx/qa/unit/gallery/test_gallery.cxx index fc3a89c50771..0919a09503eb 100644 --- a/svx/qa/unit/gallery/test_gallery.cxx +++ b/svx/qa/unit/gallery/test_gallery.cxx @@ -166,7 +166,7 @@ void GalleryObjTest::TestThemeURLCase() CPPUNIT_ASSERT_MESSAGE("Could not create gallery instance", (pGallery != nullptr)); // Mixed Case Theme Name - const OUString myThemeName = "AddyTestTheme"; + constexpr OUString myThemeName = u"AddyTestTheme"_ustr; CPPUNIT_ASSERT_MESSAGE("Could not create theme", pGallery->CreateTheme(myThemeName)); CPPUNIT_ASSERT_MESSAGE("Could not find theme", pGallery->HasTheme(myThemeName)); @@ -243,7 +243,7 @@ void GalleryObjTest::TestGalleryThemeEntry() std::unique_ptr pGallery(new Gallery(aGalleryURL)); CPPUNIT_ASSERT_MESSAGE("Could not create gallery instance", (pGallery != nullptr)); - const OUString myThemeName = "addytesttheme"; + constexpr OUString myThemeName = u"addytesttheme"_ustr; CPPUNIT_ASSERT_MESSAGE("Could not create theme", pGallery->CreateTheme(myThemeName)); CPPUNIT_ASSERT_MESSAGE("Could not find theme", pGallery->HasTheme(myThemeName)); @@ -251,8 +251,8 @@ void GalleryObjTest::TestGalleryThemeEntry() const GalleryThemeEntry* mpThemeEntry = pGallery->GetThemeInfo(myThemeName); // Check Theme Name - CPPUNIT_ASSERT_EQUAL_MESSAGE("Theme name doesn't match", mpThemeEntry->GetThemeName(), - myThemeName); + CPPUNIT_ASSERT_EQUAL_MESSAGE("Theme name doesn't match", myThemeName, + mpThemeEntry->GetThemeName()); // Check URLs GalleryStorageLocations& rGalleryStorageLocations = mpThemeEntry->getGalleryStorageLocations(); @@ -458,7 +458,7 @@ void GalleryObjTest::TestGetThemeNameFromGalleryTheme() std::unique_ptr pGallery(new Gallery(aGalleryURL)); CPPUNIT_ASSERT_MESSAGE("Could not create gallery instance", (pGallery != nullptr)); - const OUString myThemeName = "addytesttheme"; + constexpr OUString myThemeName = u"addytesttheme"_ustr; CPPUNIT_ASSERT_MESSAGE("Could not create theme", pGallery->CreateTheme(myThemeName)); CPPUNIT_ASSERT_MESSAGE("Could not find theme", pGallery->HasTheme(myThemeName)); -- cgit