From 0cda1453a0e24e9ad6884a1345e4514a86900346 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 23 Nov 2015 13:20:10 +0200 Subject: loplugin:unusedfields in svx/ Change-Id: Ia6531b1ff8882ad06084f11dd10e2b1fe3c8cf24 --- svx/inc/galobj.hxx | 1 - svx/source/accessibility/AccessibleTextHelper.cxx | 7 ++----- svx/source/dialog/imapwnd.hxx | 2 -- svx/source/form/tabwin.cxx | 8 +++----- svx/source/svdraw/svdocirc.cxx | 6 +----- svx/source/table/svdotable.cxx | 2 -- svx/source/table/tablertfimporter.cxx | 6 ++---- svx/source/table/tableundo.hxx | 1 - 8 files changed, 8 insertions(+), 25 deletions(-) (limited to 'svx') diff --git a/svx/inc/galobj.hxx b/svx/inc/galobj.hxx index 77cfb6e60659..8398a7d366c3 100644 --- a/svx/inc/galobj.hxx +++ b/svx/inc/galobj.hxx @@ -53,7 +53,6 @@ protected: BitmapEx aThumbBmp; // Allow transparence to survive GDIMetaFile aThumbMtf; INetURLObject aURL; - OUString aUserName; OUString aTitle; bool bIsValid; bool bIsThumbBmp; diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx b/svx/source/accessibility/AccessibleTextHelper.cxx index d7e673079b6f..03570b0fdf38 100644 --- a/svx/source/accessibility/AccessibleTextHelper.cxx +++ b/svx/source/accessibility/AccessibleTextHelper.cxx @@ -848,7 +848,7 @@ namespace accessibility ::accessibility::AccessibleParaManager::WeakChild > { public: - explicit AccessibleTextHelper_UpdateChildBounds( AccessibleTextHelper_Impl& rImpl ) : mrImpl(rImpl) {} + explicit AccessibleTextHelper_UpdateChildBounds() {} ::accessibility::AccessibleParaManager::WeakChild operator()( const ::accessibility::AccessibleParaManager::WeakChild& rChild ) { // retrieve hard reference from weak one @@ -875,15 +875,12 @@ namespace accessibility // identity transform return rChild; } - - private: - AccessibleTextHelper_Impl& mrImpl; }; void AccessibleTextHelper_Impl::UpdateBoundRect() { // send BOUNDRECT_CHANGED to affected children - AccessibleTextHelper_UpdateChildBounds aFunctor( *this ); + AccessibleTextHelper_UpdateChildBounds aFunctor; ::std::transform( maParaManager.begin(), maParaManager.end(), maParaManager.begin(), aFunctor ); } diff --git a/svx/source/dialog/imapwnd.hxx b/svx/source/dialog/imapwnd.hxx index 5e8afcc56d18..e4055708e097 100644 --- a/svx/source/dialog/imapwnd.hxx +++ b/svx/source/dialog/imapwnd.hxx @@ -47,8 +47,6 @@ struct NotifyPosSize { Size aPictureSize; Point aMousePos; - bool bPictureSize; - bool bMousePos; }; #define SVD_IMAP_USERDATA 0x0001 diff --git a/svx/source/form/tabwin.cxx b/svx/source/form/tabwin.cxx index ed8052efd6b4..bc3ee5784134 100644 --- a/svx/source/form/tabwin.cxx +++ b/svx/source/form/tabwin.cxx @@ -76,10 +76,8 @@ namespace { struct ColumnInfo { OUString sColumnName; - OUString sLabel; - ColumnInfo(const OUString& i_sColumnName,const OUString& i_sLabel) + ColumnInfo(const OUString& i_sColumnName) : sColumnName(i_sColumnName) - , sLabel(i_sLabel) { } }; @@ -98,9 +96,9 @@ static void lcl_addToList( SvTreeListBox& _rListBox, const uno::Reference< conta if ( xColumn->getPropertySetInfo()->hasPropertyByName(FM_PROP_LABEL) ) xColumn->getPropertyValue(FM_PROP_LABEL) >>= sLabel; if ( !sLabel.isEmpty() ) - _rListBox.InsertEntry( sLabel, nullptr, false, TREELIST_APPEND, new ColumnInfo(*pEntries,sLabel) ); + _rListBox.InsertEntry( sLabel, nullptr, false, TREELIST_APPEND, new ColumnInfo(*pEntries) ); else - _rListBox.InsertEntry( *pEntries, nullptr, false, TREELIST_APPEND, new ColumnInfo(*pEntries,sLabel) ); + _rListBox.InsertEntry( *pEntries, nullptr, false, TREELIST_APPEND, new ColumnInfo(*pEntries) ); } } diff --git a/svx/source/svdraw/svdocirc.cxx b/svx/source/svdraw/svdocirc.cxx index eee1101c59c6..0ceaab15c04c 100644 --- a/svx/source/svdraw/svdocirc.cxx +++ b/svx/source/svdraw/svdocirc.cxx @@ -363,8 +363,6 @@ struct ImpCircUser : public SdrDragStatUserData long nWdt; long nStart; long nEnd; - long nAngle; - bool bRight; // not yet implemented public: ImpCircUser() @@ -372,9 +370,7 @@ public: nHgt(0), nWdt(0), nStart(0), - nEnd(0), - nAngle(0), - bRight(false) + nEnd(0) {} void SetCreateParams(SdrDragStat& rStat); }; diff --git a/svx/source/table/svdotable.cxx b/svx/source/table/svdotable.cxx index 71b0b5a0b9b7..15bbb7f640c3 100644 --- a/svx/source/table/svdotable.cxx +++ b/svx/source/table/svdotable.cxx @@ -205,7 +205,6 @@ public: CellPos maEditPos; TableStyleSettings maTableStyle; Reference< XIndexAccess > mxTableStyle; - bool mbModifyPending; void SetModel(SdrModel* pOldModel, SdrModel* pNewModel); @@ -262,7 +261,6 @@ sal_Int32 SdrTableObjImpl::lastColCount; SdrTableObjImpl::SdrTableObjImpl() : mpTableObj( nullptr ) , mpLayouter( nullptr ) -, mbModifyPending( false ) { } diff --git a/svx/source/table/tablertfimporter.cxx b/svx/source/table/tablertfimporter.cxx index 3eb66b77e4fc..a2237c47846a 100644 --- a/svx/source/table/tablertfimporter.cxx +++ b/svx/source/table/tablertfimporter.cxx @@ -51,10 +51,9 @@ struct RTFCellDefault { SfxItemSet maItemSet; sal_Int32 mnCol; - sal_uInt16 mnTwips; // right border of the cell sal_Int32 mnColSpan; // MergeCell if >1, merged cells if 0 - explicit RTFCellDefault( SfxItemPool* pPool ) : maItemSet( *pPool ), mnCol(0), mnTwips(0 ), mnColSpan(1) {} + explicit RTFCellDefault( SfxItemPool* pPool ) : maItemSet( *pPool ), mnCol(0), mnColSpan(1) {} }; typedef std::vector< std::shared_ptr< RTFCellDefault > > RTFCellDefaultVector; @@ -64,9 +63,8 @@ struct RTFCellInfo SfxItemSet maItemSet; sal_Int32 mnStartPara; sal_Int32 mnParaCount; - sal_Int32 mnColSpan; - explicit RTFCellInfo( SfxItemPool& rPool ) : maItemSet( rPool ), mnStartPara(0), mnParaCount(0), mnColSpan(0) {} + explicit RTFCellInfo( SfxItemPool& rPool ) : maItemSet( rPool ), mnStartPara(0), mnParaCount(0) {} }; typedef std::shared_ptr< RTFCellInfo > RTFCellInfoPtr; diff --git a/svx/source/table/tableundo.hxx b/svx/source/table/tableundo.hxx index 63a8ed6ff47d..dca50c82e603 100644 --- a/svx/source/table/tableundo.hxx +++ b/svx/source/table/tableundo.hxx @@ -221,7 +221,6 @@ public: private: struct Data { - CellVector maCells; sal_Int32 mnRow; sal_Int32 mnHeight; bool mbOptimalHeight; -- cgit