From 628e96ce1fce194b30a5c2912feb8b7ec0328db0 Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Sun, 4 Nov 2018 17:06:47 +0300 Subject: tdf#120703 PVS: V547 Expression is always true/false Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- svx/source/sidebar/line/LinePropertyPanelBase.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'svx') diff --git a/svx/source/sidebar/line/LinePropertyPanelBase.cxx b/svx/source/sidebar/line/LinePropertyPanelBase.cxx index 10dad0365a1d..9b1b8152321f 100644 --- a/svx/source/sidebar/line/LinePropertyPanelBase.cxx +++ b/svx/source/sidebar/line/LinePropertyPanelBase.cxx @@ -792,7 +792,7 @@ void LinePropertyPanelBase::SelectLineStyle() return; } - const drawing::LineStyle eXLS(mpStyleItem ? mpStyleItem->GetValue() : drawing::LineStyle_NONE); + const drawing::LineStyle eXLS(mpStyleItem->GetValue()); bool bSelected(false); switch(eXLS) @@ -804,7 +804,7 @@ void LinePropertyPanelBase::SelectLineStyle() bSelected = true; break; default: - if(mpDashItem && mxLineStyleList.is()) + if(mxLineStyleList.is()) { const XDash& rDash = mpDashItem->GetDashValue(); for(long a(0);!bSelected && a < mxLineStyleList->Count(); a++) @@ -840,7 +840,7 @@ void LinePropertyPanelBase::SelectEndStyle(bool bStart) return; } - if (mpStartItem && mxLineEndList.is()) + if (mxLineEndList.is()) { const basegfx::B2DPolyPolygon& rItemPolygon = mpStartItem->GetLineStartValue(); for(long a(0);!bSelected && a < mxLineEndList->Count(); a++) @@ -869,7 +869,7 @@ void LinePropertyPanelBase::SelectEndStyle(bool bStart) return; } - if (mpEndItem && mxLineEndList.is()) + if (mxLineEndList.is()) { const basegfx::B2DPolyPolygon& rItemPolygon = mpEndItem->GetLineEndValue(); for(long a(0);!bSelected && a < mxLineEndList->Count(); a++) -- cgit