From 938821fb08e427864db6a10642f385bde9803f6c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 22 Jul 2016 14:35:27 +0200 Subject: new loplugin overrideparam verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins Reviewed-by: Noel Grandin --- svx/inc/sdr/properties/customshapeproperties.hxx | 2 +- svx/source/form/filtnav.cxx | 4 ++-- svx/source/table/cell.cxx | 2 +- svx/source/table/svdotable.cxx | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) (limited to 'svx') diff --git a/svx/inc/sdr/properties/customshapeproperties.hxx b/svx/inc/sdr/properties/customshapeproperties.hxx index 457398408cb4..577996a7d70d 100644 --- a/svx/inc/sdr/properties/customshapeproperties.hxx +++ b/svx/inc/sdr/properties/customshapeproperties.hxx @@ -43,7 +43,7 @@ namespace sdr virtual void ItemSetChanged(const SfxItemSet& rSet) override; // react on Item change - virtual void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem) override; + virtual void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem = nullptr) override; // Called after ItemChange() is done for all items. Allows local reactions on // specific item changes diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx index f48413ed54bd..2b9bebaecbdd 100644 --- a/svx/source/form/filtnav.cxx +++ b/svx/source/form/filtnav.cxx @@ -985,7 +985,7 @@ public: virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext, const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override; - virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* pViewData) override; + virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* pViewData = nullptr) override; }; const int nxDBmp = 12; @@ -1046,7 +1046,7 @@ public: virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext, const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override; - virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* pViewData) override; + virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* pViewData = nullptr) override; }; const int nxD = 4; diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx index a7f1933c2237..90f499065962 100644 --- a/svx/source/table/cell.cxx +++ b/svx/source/table/cell.cxx @@ -168,7 +168,7 @@ namespace sdr void ItemSetChanged(const SfxItemSet& rSet) override; - void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem) override; + void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem = nullptr) override; void SetStyleSheet(SfxStyleSheet* pNewStyleSheet, bool bDontRemoveHardAttr) override; diff --git a/svx/source/table/svdotable.cxx b/svx/source/table/svdotable.cxx index a113dd33e757..018ee2ed641a 100644 --- a/svx/source/table/svdotable.cxx +++ b/svx/source/table/svdotable.cxx @@ -100,7 +100,7 @@ public: // Clone() operator, normally just calls the local copy constructor BaseProperties& Clone(SdrObject& rObj) const override; - virtual void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem) override; + virtual void ItemChange(const sal_uInt16 nWhich, const SfxPoolItem* pNewItem = nullptr) override; }; TableProperties::TableProperties(SdrObject& rObj) -- cgit