From c0cc59adca23580864a2e5cdadf66212246cbfcc Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri, 26 Oct 2018 08:37:40 +0200
Subject: loplugin:singlevalfields improvement

look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 svx/source/sidebar/line/LineWidthValueSet.cxx | 7 -------
 svx/source/sidebar/line/LineWidthValueSet.hxx | 2 --
 2 files changed, 9 deletions(-)

(limited to 'svx')

diff --git a/svx/source/sidebar/line/LineWidthValueSet.cxx b/svx/source/sidebar/line/LineWidthValueSet.cxx
index f08d3462e24b..efe0db1851d1 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.cxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.cxx
@@ -25,7 +25,6 @@ namespace svx { namespace sidebar {
 
 LineWidthValueSet::LineWidthValueSet(vcl::Window* pParent)
     : ValueSet(pParent, WB_TABSTOP)
-    , pVDev(nullptr)
     , nSelItem(0)
     , bCusEnable(false)
 {
@@ -43,12 +42,6 @@ LineWidthValueSet::~LineWidthValueSet()
     disposeOnce();
 }
 
-void LineWidthValueSet::dispose()
-{
-    pVDev.disposeAndClear();
-    ValueSet::dispose();
-}
-
 void LineWidthValueSet::SetUnit(std::array<OUString,9> const & strUnits)
 {
     maStrUnits = strUnits;
diff --git a/svx/source/sidebar/line/LineWidthValueSet.hxx b/svx/source/sidebar/line/LineWidthValueSet.hxx
index abc200b64e3a..1e60de09e73c 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.hxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.hxx
@@ -30,7 +30,6 @@ class LineWidthValueSet final : public ValueSet
 public:
     explicit LineWidthValueSet(vcl::Window* pParent);
     virtual ~LineWidthValueSet() override;
-    virtual void dispose() override;
 
     void SetUnit(std::array<OUString,9> const & strUnits);
     void SetSelItem(sal_uInt16 nSel);
@@ -43,7 +42,6 @@ public:
     virtual Size    GetOptimalSize() const override;
 
 private:
-    VclPtr<VirtualDevice> pVDev;
     sal_uInt16          nSelItem;
     std::array<OUString,9> maStrUnits;
     Image           imgCus;
-- 
cgit