From 4b7316e2ff6e63bbf73e0bcf04f90b807d9829ad Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Fri, 8 Nov 2024 11:34:11 +0100 Subject: tdf#155447 a11y: Set accessible ID that Orca expects Orca commit [1] commit 40a2d302eb52295433fd84e6c254a7dbe5108a24 Author: Joanmarie Diggs Date: Thu Nov 7 14:15:07 2024 +0100 Spellcheck: Check for accessible id in more places Do the following case-insensitive checks: * If the object's accessible id starts with "suggestions" treat it as the suggestions list. * If the object's accessible id starts with "replacement" treat it as the object (likely entry) which contains the proposed replacement. * If the label's/widget's accessible id starts with "error" treat it as the container displaying the misspelled word. Note that the first of the three is based on what LO 25.2 currently exposes ("suggestionslb"). The other two are not in use yet, but adding them facilitates implementation in, and getting feedback from, apps and toolkits. Also modify the existing check for the window. We were doing an exact match on "SpellingDialog". Making that case insensitive and limiting to starts with "spelling" works with the current LO implementation and removes an implementation detail ("dialog"). introduced logic to identify more UI elements in the spelling dialog by their accessible ID. Adjust the GtkBuilder ID (which gets reported as accessible ID as well) of the drawing area that holds the misspelt text to match the expectations as mentioned in the commit message above. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24 Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280 Reviewed-by: Michael Weghorn Tested-by: Jenkins --- sw/qa/uitest/writer_tests4/spellDialog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sw/qa/uitest/writer_tests4') diff --git a/sw/qa/uitest/writer_tests4/spellDialog.py b/sw/qa/uitest/writer_tests4/spellDialog.py index 17898c4dc5b7..c01e78e10593 100644 --- a/sw/qa/uitest/writer_tests4/spellDialog.py +++ b/sw/qa/uitest/writer_tests4/spellDialog.py @@ -189,7 +189,7 @@ frog, dogg, catt""" with self.ui_test.load_file(get_url_for_data_file("tdf157992.odt")) as document: with self.ui_test.execute_modeless_dialog_through_command(".uno:SpellingAndGrammarDialog", close_button="") as xDialog: - sentence = xDialog.getChild('sentence') + sentence = xDialog.getChild('errorsentence') sentence.executeAction('TYPE', mkPropertyValues({'KEYCODE':'RIGHT'})) sentence.executeAction('TYPE', mkPropertyValues({'KEYCODE':'DELETE'})) sentence.executeAction('TYPE', mkPropertyValues({'KEYCODE':'DELETE'})) -- cgit