From 7546a904265cc0d0a0e3795cdb411cbb945a39fe Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Tue, 21 Apr 2015 12:17:27 +0200 Subject: RTF import: handle d{x,y}WrapDist* picture properties Commit e789c7f0f15a6b571de95b81e77e3a323e9f540e (RTF import of d{x,y}WrapDist* shape properties, 2013-04-09) added support for wrap distance of shapes, but that was ignored for shapes, as dmapper later overwrote the set margins. Fix this by generating the expected tokens in case of pictures, then dmapper will take care of the rest. Also add testcases for the original shape wrap distance feature that was missing. Change-Id: I6f219ee6fef71328368409d142897dbae77a0f2f --- sw/qa/extras/rtfimport/data/wrap-distance.rtf | 69 +++++++++++++++++++++++++++ sw/qa/extras/rtfimport/rtfimport.cxx | 18 +++++++ 2 files changed, 87 insertions(+) create mode 100644 sw/qa/extras/rtfimport/data/wrap-distance.rtf (limited to 'sw/qa') diff --git a/sw/qa/extras/rtfimport/data/wrap-distance.rtf b/sw/qa/extras/rtfimport/data/wrap-distance.rtf new file mode 100644 index 000000000000..217f6d955fde --- /dev/null +++ b/sw/qa/extras/rtfimport/data/wrap-distance.rtf @@ -0,0 +1,69 @@ +{\rtf1 +{\shp +{\*\shpinst\shpleft3338\shptop1718\shpright6398\shpbottom3578\shpfhdr0\shpbxcolumn\shpbxignore\shpbypara\shpbyignore\shpwr2\shpwrk0\shpfblwtxt0\shpz1\shplid1027 +{\sp +{\sn shapeType} +{\sv 3} +} +{\sp +{\sn dxWrapDistLeft} +{\sv 1080135} +} +{\sp +{\sn dyWrapDistTop} +{\sv 360045} +} +{\sp +{\sn dxWrapDistRight} +{\sv 1440180} +} +{\sp +{\sn dyWrapDistBottom} +{\sv 720090} +} +} +} +{\shp +{\*\shpinst\shpleft-7\shptop-7\shpright1019\shpbottom1019\shpfhdr0\shpbxcolumn\shpbxignore\shpbypara\shpbyignore\shpwr2\shpwrk0\shpfblwtxt0\shpz0\shplid1028 +{\sp +{\sn shapeType} +{\sv 75} +} +{\sp +{\sn pib} +{\sv +{\pict\picscalex100\picscaley100\piccropl0\piccropr0\piccropt0\piccropb0\picw1806\pich1806\picwgoal1024\pichgoal1024\pngblip\bliptag133373369 +{\*\blipuid 07f31db965a497c78cd3b098b1fb8f43} +89504e470d0a1a0a0000000d49484452000000400000004008040000000060b9550000000467414d410000b18f0bfc6105000000017352474200aece1ce90000 +00206348524d00007a26000080840000fa00000080e8000075300000ea6000003a98000017709cba513c00000002624b47440000aa8d2332000000096f464673 +0000000600000000000c7355d3000000097048597300000dd700000dd70142289b7800000009767041670000004c00000040009d31381b000001cd4944415468 +deedd93d4fc24018c0f17f89c6cdc44940e3e222be2c0e7e0417e3a8113571707632514012a320c6f84d34be2c2ec2b750f40be8e6e4a00113cfe14a5b69b108 +f4589ee71652eefafce0b9f42e3d7063822aaac3f641d173a75d3efee85b6582c0c8749c5eb7332cfb4e6f213d336ed29807304477b1c7a94db80ae9e9c934d0 +fcdd12e7ffcefcc9168f9a0059143b8cb0d2de581f609854073fbecc220f60b18722479d0d14abed8c8cb5d3293ce2949903b0d8a7047cb1c98541008cba840c +a736e1d2200046b967567f740961d3b197008873cf74835002eaac7363100009ca0d4296121675d2dc1a0440d2256428625163ed2f42cf011e8245d621b42c44 +0400485261a699706d1000092fa100d4490713220240dc25e438b1090185880ca09f8ece5c28d9843b009e82471ca25069d5cb785529bd007fdbfb8541b65b2f +531100947a51530d42c1d92f9829818e31ca4ce9421c70e427440e80712a7a89b7c8fb0906003046a5311df31cf501a01f4d0ee1b80f00bd4c398558ee0340ff +0b939a30df17002459f05d330a080a0108400002108000042000010840000210800004200001f8ce0ddf798e30dd7b38e0ce7ea16d2abc25a819cbda225337c7 +f7ff69bf8eef7f0084e08d42bdf8a03e00000025744558746372656174652d6461746500323031302d31322d32305431373a30383a33362b30313a30307ae51b1c00000025744558746d6f646966792d6461746500323031302d31322d32305431373a30383a33372b30313a30308323669c0000000049454e44ae426082} +} +} +{\sp +{\sn dxWrapDistLeft} +{\sv 1080135} +} +{\sp +{\sn dyWrapDistTop} +{\sv 360045} +} +{\sp +{\sn dxWrapDistRight} +{\sv 1440180} +} +{\sp +{\sn dyWrapDistBottom} +{\sv 720090} +} +} +} +\par +} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index f4c14c77b63a..ae2873e2a120 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -2245,6 +2245,24 @@ DECLARE_RTFIMPORT_TEST(testTdf86182, "tdf86182.rtf") CPPUNIT_ASSERT_EQUAL(text::WritingMode2::RL_TB, getProperty(getParagraph(1), "WritingMode")); } +DECLARE_RTFIMPORT_TEST(testWrapDistance, "wrap-distance.rtf") +{ + // Custom shape, handled directly in RTFSdrImport. + uno::Reference xShape = getShape(1); + CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.drawing.CustomShape"), xShape->getShapeType()); + CPPUNIT_ASSERT_EQUAL(static_cast(1), getProperty(xShape, "TopMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(2), getProperty(xShape, "BottomMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(3), getProperty(xShape, "LeftMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(4), getProperty(xShape, "RightMargin") / 1000); + + // Picture, handled in GraphicImport, shared with DOCX. + xShape = getShape(2); + CPPUNIT_ASSERT_EQUAL(static_cast(1), getProperty(xShape, "TopMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(2), getProperty(xShape, "BottomMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(3), getProperty(xShape, "LeftMargin") / 1000); + CPPUNIT_ASSERT_EQUAL(static_cast(4), getProperty(xShape, "RightMargin") / 1000); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit