From 9034207b3019e395390e5aa9eaa1a11ca81c63b5 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Mon, 12 Mar 2018 16:30:55 +0100 Subject: sw XHTML export: always write images as PNG in ReqIF mode JPG image would have to be JPG + PNG fallback, at which point it's easier to just write PNG. Change-Id: I6e4f0759244d29735fdcda8e050d198f118c737d Reviewed-on: https://gerrit.libreoffice.org/51151 Reviewed-by: Miklos Vajna Tested-by: Jenkins --- sw/qa/extras/htmlexport/data/reqif-jpg-img.xhtml | 4 ++++ sw/qa/extras/htmlexport/data/reqif-ole-img.jpg | Bin 0 -> 696 bytes sw/qa/extras/htmlexport/htmlexport.cxx | 12 ++++++++++++ 3 files changed, 16 insertions(+) create mode 100644 sw/qa/extras/htmlexport/data/reqif-jpg-img.xhtml create mode 100644 sw/qa/extras/htmlexport/data/reqif-ole-img.jpg (limited to 'sw/qa') diff --git a/sw/qa/extras/htmlexport/data/reqif-jpg-img.xhtml b/sw/qa/extras/htmlexport/data/reqif-jpg-img.xhtml new file mode 100644 index 000000000000..da7276192a31 --- /dev/null +++ b/sw/qa/extras/htmlexport/data/reqif-jpg-img.xhtml @@ -0,0 +1,4 @@ + + OLE Object + + diff --git a/sw/qa/extras/htmlexport/data/reqif-ole-img.jpg b/sw/qa/extras/htmlexport/data/reqif-ole-img.jpg new file mode 100644 index 000000000000..ca9183e9d308 Binary files /dev/null and b/sw/qa/extras/htmlexport/data/reqif-ole-img.jpg differ diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx b/sw/qa/extras/htmlexport/htmlexport.cxx index 5c8f5cfaf5f1..289fcb2a26d7 100644 --- a/sw/qa/extras/htmlexport/htmlexport.cxx +++ b/sw/qa/extras/htmlexport/htmlexport.cxx @@ -424,6 +424,18 @@ DECLARE_HTMLEXPORT_ROUNDTRIP_TEST(testReqIfPngImg, "reqif-png-img.xhtml") CPPUNIT_ASSERT(aStream.indexOf("Seek(STREAM_SEEK_TO_END); + sal_uInt64 nLength = pStream->Tell(); + pStream->Seek(0); + OString aStream(read_uInt8s_ToOString(*pStream, nLength)); + // This was image/jpeg, JPG was not converted to PNG in ReqIF mode. + CPPUNIT_ASSERT(aStream.indexOf("type=\"image/png\"") != -1); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit