From be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928 Mon Sep 17 00:00:00 2001 From: Justin Luth Date: Thu, 21 Jul 2022 13:56:30 -0400 Subject: [API CHANGE] tdf#85592: deprecate .uno:BackColor, use .uno:CharBackColor EditEngine stuff uses CharBackColor, while SW used BackColor. Deprecate the SW-only SID. What does this do? It allows the toolbar "Character Highlighting Color" to work with both body text (previously BackColor) and comment text(CharBackColor). Otherwise, the toolbar item was disabled when moving into a comment. (Shapes/Textboxes got their own formatting toolbar, so those are unaffected.) AFAIK, after this commit, SID_ATTR_CHAR_COLOR_BACKGROUND should still work fine for API calls, or for customized toolbars. That's why I didn't try to remove it completely - just deprecate. Do I know what I am doing here? No, although I'm fairly confident nontheless, and I've had some good help from reviewers. Change-Id: I0afcbdb1b91c872f6d47f3c82c573f3b9fea6dfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137334 Tested-by: Jenkins Reviewed-by: Justin Luth --- sw/uiconfig/sweb/toolbar/textobjectbar.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sw/uiconfig/sweb/toolbar') diff --git a/sw/uiconfig/sweb/toolbar/textobjectbar.xml b/sw/uiconfig/sweb/toolbar/textobjectbar.xml index aac0785fd003..9c4c45fd682b 100644 --- a/sw/uiconfig/sweb/toolbar/textobjectbar.xml +++ b/sw/uiconfig/sweb/toolbar/textobjectbar.xml @@ -50,7 +50,7 @@ - + -- cgit