From c0cbd13c945c5f47057b413efc88b2e3bb72d025 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Mon, 26 Apr 2021 09:36:14 +0100 Subject: Related: tdf#130326 drop ScContentTree::ObjectFresh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this was introduced as part of the large IA2 integration commit b41332475783c31136673fb44cf4c411bb0148f8 Author: Steve Yin Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 Both calc and writer gained the feature that "space" in the navigator for drawing objects selects the highlighted object, extending the selection if another one is already selected. (notably impress was left unchanged) In calc, but not writer, an ObjectFresh was added which fires on every SfxHintId::ScKillEditView which is broadcast on every exit of the cursor from a cell. Its purpose seems to be primarily to re-highlight the last selected-by-keyboard entry on a content refresh. As far as I can tell this doesn't seem necessary and we already refresh content on SfxHintId::ScDrawChanged events so we shouldn't need to additionally refresh on ScKillEditView and refreshing on every ScKillEditView is very slow on navigating through a calc document with a lot of drawing objects. Change-Id: I64b2840f8510d474314d108e657fc3367f8ab6c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114650 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara --- sw/source/uibase/utlui/content.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sw') diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index 221a161d21b1..2b3b057ab7b2 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -3608,8 +3608,8 @@ IMPL_LINK(SwContentTree, KeyInputHdl, const KeyEvent&, rEvent, bool) } } } - //Make KEY_SPACE has same function as DoubleClick , - //and realize multi-selection . + //Make KEY_SPACE has same function as DoubleClick, and realize + //multi-selection. else if (aCode.GetCode() == KEY_SPACE && 0 == aCode.GetModifier()) { std::unique_ptr xEntry(m_xTreeView->make_iterator()); -- cgit