From 0063cf285696951e336b9cec1da8881997b286ce Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 18 Nov 2014 10:01:21 +0200 Subject: java: make fields final where possible found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec --- swext/mediawiki/src/com/sun/star/wiki/Settings.java | 6 +++--- swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java | 6 +++--- swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java | 6 +++--- swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java | 4 ++-- .../src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java | 2 +- swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) (limited to 'swext/mediawiki') diff --git a/swext/mediawiki/src/com/sun/star/wiki/Settings.java b/swext/mediawiki/src/com/sun/star/wiki/Settings.java index 74d60180ef28..9580f9ea4570 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/Settings.java +++ b/swext/mediawiki/src/com/sun/star/wiki/Settings.java @@ -40,10 +40,10 @@ public class Settings private static Settings m_instance; - private XComponentContext m_xContext; + private final XComponentContext m_xContext; private int lastUsedWikiServer = 0; - private List> m_WikiConnections = new ArrayList>(); - private List> m_aWikiDocs = new ArrayList>(); + private final List> m_WikiConnections = new ArrayList>(); + private final List> m_aWikiDocs = new ArrayList>(); private Settings( XComponentContext ctx ) { diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java b/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java index 6b87778808eb..e16db7156831 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java +++ b/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java @@ -33,7 +33,7 @@ import com.sun.star.uno.XComponentContext; public class WikiArticle { - private XComponentContext m_xContext; + private final XComponentContext m_xContext; private String m_sEditTime = ""; private String m_sEditToken = ""; @@ -44,9 +44,9 @@ public class WikiArticle private String m_sWikiUser; private String m_sWikiPass; - private String m_sTitle = ""; + private final String m_sTitle; - private URI m_aMainURI; + private final URI m_aMainURI; private HostConfiguration m_aHostConfig; diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java index 2e262fb37356..aef6cb6a29b6 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java +++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java @@ -37,9 +37,9 @@ public class WikiEditSettingDialog extends WikiDialog private static final String sOKMethod = "OK"; - private String[] Methods = {sOKMethod }; - private Map setting; - private boolean addMode; + private final String[] Methods = {sOKMethod }; + private final Map setting; + private final boolean addMode; private boolean m_bAllowURLChange = true; public WikiEditSettingDialog( XComponentContext xContext, String DialogURL ) diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java index 15ece8c515df..3ad6b5c410b9 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java +++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java @@ -57,10 +57,10 @@ public final class WikiEditorImpl extends WeakBase private static final String protocolName = "vnd.com.sun.star.wiki:"; private final XComponentContext m_xContext; - private Map m_statusListeners = new HashMap(); + private final Map m_statusListeners = new HashMap(); private XFrame m_xFrame; private XModel m_xModel; - private Settings m_aSettings; + private final Settings m_aSettings; private String m_aFilterName; public WikiEditorImpl( XComponentContext xContext ) diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java b/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java index 9c7ff7939b3a..c3a1f462a89f 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java +++ b/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java @@ -49,7 +49,7 @@ public final class WikiOptionsEventHandlerImpl extends WeakBase private static final String sOk = "ok"; private static final String sBack = "back"; - private XComponentContext m_xContext; + private final XComponentContext m_xContext; private XDialog m_xDialog; private XControlContainer m_xControlContainer; diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java index 22d8e3d0a439..43fba5c24f84 100644 --- a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java +++ b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java @@ -34,7 +34,7 @@ public class WikiPropDialog extends WikiDialog{ private static final String sArticleTextMethod = "ArticleTextChange"; private static final String sAddWikiMethod = "AddWiki"; - private String[] m_pMethods = {sSendMethod, sWikiListMethod, sArticleTextMethod, sAddWikiMethod}; + private final String[] m_pMethods = {sSendMethod, sWikiListMethod, sArticleTextMethod, sAddWikiMethod}; private String m_sWikiTitle = ""; private String m_sWikiEngineURL = ""; -- cgit