From 6aecd49aa6de7c7f65c3c240ee3b7db36497df4d Mon Sep 17 00:00:00 2001 From: Noel Date: Fri, 19 Feb 2021 14:32:47 +0200 Subject: loplugin:refcounting in test Change-Id: I1e741283bffae6c3e40f4e61aaed5c085997c74f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111214 Tested-by: Jenkins Reviewed-by: Noel Grandin --- test/source/lang/xcomponent.cxx | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) (limited to 'test') diff --git a/test/source/lang/xcomponent.cxx b/test/source/lang/xcomponent.cxx index abe5111e4f2a..286f66c5c77a 100644 --- a/test/source/lang/xcomponent.cxx +++ b/test/source/lang/xcomponent.cxx @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -38,9 +39,8 @@ namespace apitest void XComponent::testAddEventListener() { Reference xComponent(init(), uno::UNO_QUERY_THROW); - auto pListenerAdded(new TestEventListener()); - Reference xListenerAdded(pListenerAdded); - xComponent->addEventListener(xListenerAdded); + rtl::Reference pListenerAdded(new TestEventListener()); + xComponent->addEventListener(pListenerAdded); xComponent->dispose(); CPPUNIT_ASSERT_EQUAL(true, pListenerAdded->m_hasDisposingCalled); } @@ -48,10 +48,9 @@ void XComponent::testAddEventListener() void XComponent::testRemoveEventListener() { Reference xComponent(init(), uno::UNO_QUERY_THROW); - auto pListenerAddedAndRemoved(new TestEventListener()); - Reference xListenerAddedAndRemoved(pListenerAddedAndRemoved); - xComponent->addEventListener(xListenerAddedAndRemoved); - xComponent->removeEventListener(xListenerAddedAndRemoved); + rtl::Reference pListenerAddedAndRemoved(new TestEventListener()); + xComponent->addEventListener(pListenerAddedAndRemoved); + xComponent->removeEventListener(pListenerAddedAndRemoved); xComponent->dispose(); CPPUNIT_ASSERT_EQUAL(false, pListenerAddedAndRemoved->m_hasDisposingCalled); } @@ -59,9 +58,8 @@ void XComponent::testRemoveEventListener() void XComponent::testDispose() { Reference xComponent(init(), uno::UNO_QUERY_THROW); - auto pListenerAdded(new TestEventListener()); - Reference xListenerAdded(pListenerAdded); - xComponent->addEventListener(xListenerAdded); + rtl::Reference pListenerAdded(new TestEventListener()); + xComponent->addEventListener(pListenerAdded); xComponent->dispose(); CPPUNIT_ASSERT_EQUAL(true, pListenerAdded->m_hasDisposingCalled); } @@ -69,9 +67,8 @@ void XComponent::testDispose() void XComponent::testDisposedByDesktopTerminate() { Reference xComponent(init(), uno::UNO_QUERY_THROW); - auto pListenerAdded(new TestEventListener()); - Reference xListenerAdded(pListenerAdded); - xComponent->addEventListener(xListenerAdded); + rtl::Reference pListenerAdded(new TestEventListener()); + xComponent->addEventListener(pListenerAdded); triggerDesktopTerminate(); CPPUNIT_ASSERT_EQUAL(true, pListenerAdded->m_hasDisposingCalled); } -- cgit