From 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f Mon Sep 17 00:00:00 2001 From: Christian Lohmaier Date: Thu, 2 May 2024 11:19:38 +0200 Subject: makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …by a simple/static $(gb_CustomTarget_workdir)/foo The build system has a lot of overly complicated leftovers from when it was introduced and had not only deal with split repositories but also had to coexist with another buildsystem. Along with lots of copy'n'paste along the years the makefiles became hard to grasp for newcomers with all our calls and evals. As a first step to streamline that, the macros from TargetLocations that simply prefix a static path to the argument (and similar of the same kind) are a natural pick before simplifying the rules themselves/getting rid of a bunch of eval statements. Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005 Tested-by: Jenkins Reviewed-by: Christian Lohmaier --- tools/CustomTarget_reversemap.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tools') diff --git a/tools/CustomTarget_reversemap.mk b/tools/CustomTarget_reversemap.mk index 94a697f1a6af..c90413c2b3a6 100644 --- a/tools/CustomTarget_reversemap.mk +++ b/tools/CustomTarget_reversemap.mk @@ -9,11 +9,11 @@ $(eval $(call gb_CustomTarget_CustomTarget,tools/string)) $(call gb_CustomTarget_get_target,tools/string) : \ - $(call gb_CustomTarget_get_workdir,tools/string)/reversemap.cxx + $(gb_CustomTarget_workdir)/tools/string/reversemap.cxx -$(call gb_CustomTarget_get_workdir,tools/string)/reversemap.cxx : \ +$(gb_CustomTarget_workdir)/tools/string/reversemap.cxx : \ $(call gb_Executable_get_runtime_dependencies,bestreversemap) \ - | $(call gb_CustomTarget_get_workdir,tools/string)/.dir + | $(gb_CustomTarget_workdir)/tools/string/.dir $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),BRM,1) $(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),BRM) $(call gb_Helper_execute,bestreversemap > $@) -- cgit