From cfbd830e9c4d1877989bc4ad93109551a0a4b0b7 Mon Sep 17 00:00:00 2001 From: Mike Kaganski <mike.kaganski@collabora.com> Date: Mon, 11 Feb 2019 09:02:13 +0300 Subject: tdf#120703 PVS: remove redundant static casts V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> --- ucb/source/core/FileAccess.cxx | 4 ++-- ucb/source/core/cmdenv.cxx | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'ucb/source') diff --git a/ucb/source/core/FileAccess.cxx b/ucb/source/core/FileAccess.cxx index 98ac5260817d..21d4e0b9fbf0 100644 --- a/ucb/source/core/FileAccess.cxx +++ b/ucb/source/core/FileAccess.cxx @@ -492,7 +492,7 @@ Reference< XInputStream > OFileAccess::openFileRead( const OUString& FileURL ) INetURLObject aObj( FileURL, INetProtocol::File ); ucbhelper::Content aCnt( aObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ), mxEnvironment.get(), comphelper::getProcessComponentContext() ); - Reference< XActiveDataSink > xSink = static_cast<XActiveDataSink*>(new OActiveDataSink); + Reference<XActiveDataSink> xSink = new OActiveDataSink; try { @@ -519,7 +519,7 @@ Reference< XOutputStream > OFileAccess::openFileWrite( const OUString& FileURL ) Reference< XStream > OFileAccess::openFileReadWrite( const OUString& FileURL ) { - Reference< XActiveDataStreamer > xSink = static_cast<XActiveDataStreamer*>(new OActiveDataStreamer); + Reference<XActiveDataStreamer> xSink = new OActiveDataStreamer; OpenCommandArgument2 aArg; aArg.Mode = OpenMode::DOCUMENT; diff --git a/ucb/source/core/cmdenv.cxx b/ucb/source/core/cmdenv.cxx index 8c84e37a90cb..b49ebc3d4f51 100644 --- a/ucb/source/core/cmdenv.cxx +++ b/ucb/source/core/cmdenv.cxx @@ -129,8 +129,7 @@ static uno::Reference< uno::XInterface > UcbCommandEnvironment_CreateInstance( const uno::Reference< lang::XMultiServiceFactory> & /*rSMgr*/ ) { - lang::XServiceInfo * pX = static_cast< lang::XServiceInfo * >( - new UcbCommandEnvironment ); + lang::XServiceInfo* pX = new UcbCommandEnvironment; return uno::Reference< uno::XInterface >::query( pX ); } -- cgit