From 9ffdf7adc00d8e9d931184d3008f4e505e4a5024 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 16 May 2018 10:05:56 +0200 Subject: loplugin:unusedfields in tools..xmlhelp Change-Id: I5e909a8def86ce9ad150440e6c6ad304e855cc69 Reviewed-on: https://gerrit.libreoffice.org/54415 Tested-by: Jenkins Reviewed-by: Noel Grandin --- ucb/source/ucp/file/filinsreq.cxx | 5 ++--- ucb/source/ucp/file/filinsreq.hxx | 1 - ucb/source/ucp/file/filprp.cxx | 5 ++--- ucb/source/ucp/file/filprp.hxx | 1 - ucb/source/ucp/file/filtask.cxx | 3 +-- ucb/source/ucp/file/filtask.hxx | 1 - 6 files changed, 5 insertions(+), 11 deletions(-) (limited to 'ucb') diff --git a/ucb/source/ucp/file/filinsreq.cxx b/ucb/source/ucp/file/filinsreq.cxx index e33f9183d92a..9275b47aeab3 100644 --- a/ucb/source/ucp/file/filinsreq.cxx +++ b/ucb/source/ucp/file/filinsreq.cxx @@ -47,7 +47,6 @@ XInteractionRequestImpl::XInteractionRequestImpl( p2( new XInteractionAbortImpl ), m_nErrorCode(0), m_nMinorError(0), - m_aClashingName(aClashingName), m_xOrigin(xOrigin) { if( pShell ) @@ -59,7 +58,7 @@ XInteractionRequestImpl::XInteractionRequestImpl( if(m_nErrorCode == TASKHANDLING_FOLDER_EXISTS_MKDIR) { NameClashException excep; - excep.Name = m_aClashingName; + excep.Name = aClashingName; excep.Classification = InteractionClassification_ERROR; excep.Context = m_xOrigin; excep.Message = "folder exists and overwrite forbidden"; @@ -72,7 +71,7 @@ XInteractionRequestImpl::XInteractionRequestImpl( PropertyValue prop; prop.Name = "ResourceName"; prop.Handle = -1; - prop.Value <<= m_aClashingName; + prop.Value <<= aClashingName; Sequence seq(1); seq[0] <<= prop; excep.Arguments = seq; diff --git a/ucb/source/ucp/file/filinsreq.hxx b/ucb/source/ucp/file/filinsreq.hxx index 93c526f3571d..9d115bbfa0e7 100644 --- a/ucb/source/ucp/file/filinsreq.hxx +++ b/ucb/source/ucp/file/filinsreq.hxx @@ -135,7 +135,6 @@ class XInteractionSupplyNameImpl : public cppu::WeakImplHelper< css::uno::Reference m_xRequest; - OUString m_aClashingName; css::uno::Reference< css::uno::XInterface> m_xOrigin; }; diff --git a/ucb/source/ucp/file/filprp.cxx b/ucb/source/ucp/file/filprp.cxx index 179eb487098a..a92fd0959854 100644 --- a/ucb/source/ucp/file/filprp.cxx +++ b/ucb/source/ucp/file/filprp.cxx @@ -36,7 +36,6 @@ using namespace com::sun::star::ucb; XPropertySetInfo_impl::XPropertySetInfo_impl( TaskManager* pMyShell,const OUString& aUnqPath ) : m_pMyShell( pMyShell ), - m_count( 0 ), m_seq( 0 ) { m_pMyShell->m_pProvider->acquire(); @@ -48,9 +47,10 @@ XPropertySetInfo_impl::XPropertySetInfo_impl( TaskManager* pMyShell,const OUStri m_seq.realloc( properties.size() ); + sal_Int32 count = 0; while( it1 != properties.end() ) { - m_seq[ m_count++ ] = beans::Property( it1->getPropertyName(), + m_seq[ count++ ] = beans::Property( it1->getPropertyName(), it1->getHandle(), it1->getType(), it1->getAttributes() ); @@ -61,7 +61,6 @@ XPropertySetInfo_impl::XPropertySetInfo_impl( TaskManager* pMyShell,const OUStri XPropertySetInfo_impl::XPropertySetInfo_impl( TaskManager* pMyShell,const Sequence< beans::Property >& seq ) : m_pMyShell( pMyShell ), - m_count( seq.getLength() ), m_seq( seq ) { m_pMyShell->m_pProvider->acquire(); diff --git a/ucb/source/ucp/file/filprp.hxx b/ucb/source/ucp/file/filprp.hxx index 1be9af995c7d..0f7e2b3e6ac1 100644 --- a/ucb/source/ucp/file/filprp.hxx +++ b/ucb/source/ucp/file/filprp.hxx @@ -48,7 +48,6 @@ class XPropertySetInfo_impl : public cppu::WeakImplHelper< private: TaskManager* m_pMyShell; - sal_Int32 m_count; css::uno::Sequence< css::beans::Property > m_seq; }; } diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx index 85164c30792a..32753ba905b0 100644 --- a/ucb/source/ucp/file/filtask.cxx +++ b/ucb/source/ucp/file/filtask.cxx @@ -118,7 +118,6 @@ TaskManager::MyProperty::~MyProperty() TaskManager::TaskManager( const uno::Reference< uno::XComponentContext >& rxContext, FileProvider* pProvider, bool bWithConfig ) : m_nCommandId( 0 ), - m_bWithConfig( bWithConfig ), m_pProvider( pProvider ), m_xContext( rxContext ), Title( "Title" ), @@ -351,7 +350,7 @@ TaskManager::TaskManager( const uno::Reference< uno::XComponentContext >& rxCont m_sCommandInfo[8].Handle = -1; m_sCommandInfo[8].ArgType = cppu::UnoType::get(); - if(m_bWithConfig) + if(bWithConfig) { uno::Reference< XPropertySetRegistryFactory > xRegFac = ucb::Store::create( m_xContext ); // Open/create a registry diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx index 966a0cdbcbbc..d50400f082de 100644 --- a/ucb/source/ucp/file/filtask.hxx +++ b/ucb/source/ucp/file/filtask.hxx @@ -503,7 +503,6 @@ namespace fileaccess static bool getUrlFromUnq( const OUString& Unq, OUString& Url ); - bool m_bWithConfig; FileProvider* m_pProvider; css::uno::Reference< css::uno::XComponentContext > m_xContext; css::uno::Reference< css::ucb::XPropertySetRegistry > m_xFileRegistry; -- cgit