From abe39f7781f59b96c5a8d3dd5b41c60fdf04ad84 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri, 6 Mar 2020 14:40:40 +0200
Subject: improve loplugin:unusedfields

noticed something that wasn't being picked up, wrote some tests,
and found an unhandled case in Plugin::getParentFunctionDecl

Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 ucb/source/ucp/ftp/ftpintreq.cxx | 3 +--
 ucb/source/ucp/ftp/ftpintreq.hxx | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

(limited to 'ucb')

diff --git a/ucb/source/ucp/ftp/ftpintreq.cxx b/ucb/source/ucp/ftp/ftpintreq.cxx
index 08b857590b9e..62c499b168ae 100644
--- a/ucb/source/ucp/ftp/ftpintreq.cxx
+++ b/ucb/source/ucp/ftp/ftpintreq.cxx
@@ -59,11 +59,10 @@ void SAL_CALL XInteractionDisapproveImpl::select()
 
 XInteractionRequestImpl::XInteractionRequestImpl()
     : p1( new XInteractionApproveImpl )
-    , p2( new XInteractionDisapproveImpl )
 {
     std::vector<uno::Reference<task::XInteractionContinuation>> continuations{
         Reference<XInteractionContinuation>(p1),
-        Reference<XInteractionContinuation>(p2) };
+        Reference<XInteractionContinuation>(new XInteractionDisapproveImpl) };
     UnsupportedNameClashException excep;
     excep.NameClash = NameClash::ERROR;
     m_xRequest.set(new ::comphelper::OInteractionRequest(Any(excep), continuations));
diff --git a/ucb/source/ucp/ftp/ftpintreq.hxx b/ucb/source/ucp/ftp/ftpintreq.hxx
index 515b4c38870d..315ce9703330 100644
--- a/ucb/source/ucp/ftp/ftpintreq.hxx
+++ b/ucb/source/ucp/ftp/ftpintreq.hxx
@@ -72,7 +72,6 @@ namespace ftp {
     private:
 
         XInteractionApproveImpl* const p1;
-        XInteractionDisapproveImpl* const p2;
 
         css::uno::Reference<css::task::XInteractionRequest> m_xRequest;
 
-- 
cgit