From c158c00489d35af7f5f9278b8ee545678d6a42e5 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 7 Sep 2016 08:49:37 +0200 Subject: loplugin:constantparam in framework..vbahelper Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc --- ucbhelper/source/client/proxydecider.cxx | 6 +++--- ucbhelper/source/provider/simpleauthenticationrequest.cxx | 12 ++++-------- 2 files changed, 7 insertions(+), 11 deletions(-) (limited to 'ucbhelper') diff --git a/ucbhelper/source/client/proxydecider.cxx b/ucbhelper/source/client/proxydecider.cxx index 8b7630b9db17..d64cbd5df979 100644 --- a/ucbhelper/source/client/proxydecider.cxx +++ b/ucbhelper/source/client/proxydecider.cxx @@ -82,8 +82,8 @@ class HostnameCache sal_uInt32 m_nCapacity; public: - explicit HostnameCache( sal_uInt32 nCapacity ) - : m_nCapacity( nCapacity ) {} + explicit HostnameCache() + : m_nCapacity( 256 ) {} bool get( const OUString & rKey, OUString & rValue ) const { @@ -288,7 +288,7 @@ bool getConfigInt32Value( InternetProxyDecider_Impl::InternetProxyDecider_Impl( const uno::Reference< uno::XComponentContext >& rxContext ) : m_nProxyType( 0 ), - m_aHostnames( 256 ) // cache size + m_aHostnames() { try { diff --git a/ucbhelper/source/provider/simpleauthenticationrequest.cxx b/ucbhelper/source/provider/simpleauthenticationrequest.cxx index a1e0ae4f25d8..ddc8fc9e4079 100644 --- a/ucbhelper/source/provider/simpleauthenticationrequest.cxx +++ b/ucbhelper/source/provider/simpleauthenticationrequest.cxx @@ -60,7 +60,6 @@ SimpleAuthenticationRequest::SimpleAuthenticationRequest( true, true, aRequest.HasAccount, - true/*bAllowPersistentStoring*/, bAllowUseSystemCredentials, bAllowSessionStoring ); } @@ -100,8 +99,8 @@ SimpleAuthenticationRequest::SimpleAuthenticationRequest( eUserNameType == ENTITY_MODIFY, ePasswordType == ENTITY_MODIFY, false, - true, - false ); + false, + true ); } @@ -111,7 +110,6 @@ void SimpleAuthenticationRequest::initialize( bool bCanSetUserName, bool bCanSetPassword, bool bCanSetAccount, - bool bAllowPersistentStoring, bool bAllowUseSystemCredentials, bool bAllowSessionStoring ) { @@ -124,8 +122,7 @@ void SimpleAuthenticationRequest::initialize( if( bAllowSessionStoring ) nSize++; - if( bAllowPersistentStoring ) - nSize++; + nSize++; uno::Sequence< ucb::RememberAuthentication > aRememberModes( nSize ); aRememberModes[ nPos++ ] = ucb::RememberAuthentication_NO; @@ -133,8 +130,7 @@ void SimpleAuthenticationRequest::initialize( if( bAllowSessionStoring ) aRememberModes[ nPos++ ] = ucb::RememberAuthentication_SESSION; - if ( bAllowPersistentStoring ) - aRememberModes[ nPos++ ] = ucb::RememberAuthentication_PERSISTENT; + aRememberModes[ nPos++ ] = ucb::RememberAuthentication_PERSISTENT; m_xAuthSupplier = new InteractionSupplyAuthentication( -- cgit