From e3133ae2371b6e2d4b47daa6a3487ea4f2753315 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 23 Jan 2014 18:43:53 +0100 Subject: Let C++ inline functions return bool instead of sal_Bool ...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9 --- unotools/source/config/compatibility.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'unotools') diff --git a/unotools/source/config/compatibility.cxx b/unotools/source/config/compatibility.cxx index 78f280ace2e6..34fe2e784a77 100644 --- a/unotools/source/config/compatibility.cxx +++ b/unotools/source/config/compatibility.cxx @@ -401,7 +401,7 @@ SvtCompatibilityOptions_Impl::SvtCompatibilityOptions_Impl() lValues[ nPosition++ ] >>= aItem.bExpandWordSpace; m_aOptions.AppendEntry( aItem ); - if ( !bDefaultFound && aItem.sName.equals( COMPATIBILITY_DEFAULT_NAME ) != sal_False ) + if ( !bDefaultFound && aItem.sName.equals( COMPATIBILITY_DEFAULT_NAME ) ) { SvtSysLocale aSysLocale; com::sun::star::lang::Locale aLocale = aSysLocale.GetLanguageTag().getLocale(); @@ -561,7 +561,7 @@ void SvtCompatibilityOptions_Impl::AppendItem( const OUString& _sName, m_aOptions.AppendEntry( aItem ); // default item reset? - if ( _sName.equals( COMPATIBILITY_DEFAULT_NAME ) != sal_False ) + if ( _sName.equals( COMPATIBILITY_DEFAULT_NAME ) ) m_aDefOptions = aItem; SetModified(); -- cgit