From 63a68064bb33f180b8a231f7524d99405d910226 Mon Sep 17 00:00:00 2001 From: Noel Date: Fri, 15 Jan 2021 14:49:12 +0200 Subject: make the Color constructors explicitly specify transparency to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin --- vbahelper/source/vbahelper/vbacolorformat.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'vbahelper') diff --git a/vbahelper/source/vbahelper/vbacolorformat.cxx b/vbahelper/source/vbahelper/vbacolorformat.cxx index 49089f994517..ec33f899054a 100644 --- a/vbahelper/source/vbahelper/vbacolorformat.cxx +++ b/vbahelper/source/vbahelper/vbacolorformat.cxx @@ -76,7 +76,7 @@ ScVbaColorFormat::getRGB() default: throw uno::RuntimeException( "Second parameter of ColorFormat is wrong." ); } - nRGB = OORGBToXLRGB( Color(nRGB) ); + nRGB = OORGBToXLRGB( Color(ColorTransparency, nRGB) ); return nRGB; } -- cgit