From 46009c851764857e67202875cea7d4566bf6abeb Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Sun, 10 Nov 2024 23:01:07 +0100 Subject: vcl: Return unique_ptr in weld::MessageDialog::weld_message_area The returned weld::Container* (but not the associated toolkit widget) is owned by the caller. Make that more obvious by returning a unique_ptr instead of a raw pointer. This is also consistent with what other methods returning instances for which the caller takes over ownership (like weld::Widget::weld_parent) do, whereas e.g. weld::Notebook::get_page returns a weld::Container* that is owned by the weld::Notebook instance, not the caller. Change-Id: Ia839fac90ea93b9ac6be5819aa4bb3261a775f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176363 Tested-by: Jenkins Reviewed-by: Michael Weghorn --- vcl/inc/salvtables.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'vcl/inc/salvtables.hxx') diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx index b42a3f71ebc2..e6341e4b87ed 100644 --- a/vcl/inc/salvtables.hxx +++ b/vcl/inc/salvtables.hxx @@ -1215,7 +1215,7 @@ public: virtual OUString get_secondary_text() const override; - virtual weld::Container* weld_message_area() override; + virtual std::unique_ptr weld_message_area() override; }; class SalInstanceLinkButton : public SalInstanceWidget, public virtual weld::LinkButton -- cgit