From 00659bcdbbb167596e6fd18e283a54819dd6fe91 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 6 Feb 2023 18:14:16 +0200 Subject: improve readability of VirtualDevice constructor (a) It is not obvious what DeviceFormat::DEFAULT means (b) There are two parameters (each with two states), but only really 2 possible overall states So (1) use more useful names (2) combine the two parameters into one enum Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589 Tested-by: Jenkins Reviewed-by: Noel Grandin --- vcl/qa/cppunit/FontFeatureTest.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'vcl/qa/cppunit/FontFeatureTest.cxx') diff --git a/vcl/qa/cppunit/FontFeatureTest.cxx b/vcl/qa/cppunit/FontFeatureTest.cxx index 9858c96e0a9f..9d47ceb17063 100644 --- a/vcl/qa/cppunit/FontFeatureTest.cxx +++ b/vcl/qa/cppunit/FontFeatureTest.cxx @@ -42,7 +42,7 @@ void FontFeatureTest::testGetFontFeaturesGraphite() { #if HAVE_MORE_FONTS ScopedVclPtrInstance aVDev(*Application::GetDefaultDevice(), - DeviceFormat::DEFAULT, DeviceFormat::DEFAULT); + DeviceFormat::WITH_ALPHA); aVDev->SetOutputSizePixel(Size(10, 10)); OUString aFontName("Linux Libertine G"); @@ -126,7 +126,7 @@ void FontFeatureTest::testGetFontFeaturesOpenType() { #if HAVE_MORE_FONTS ScopedVclPtrInstance aVDev(*Application::GetDefaultDevice(), - DeviceFormat::DEFAULT, DeviceFormat::DEFAULT); + DeviceFormat::WITH_ALPHA); aVDev->SetOutputSizePixel(Size(10, 10)); OUString aFontName("Amiri"); @@ -175,7 +175,7 @@ void FontFeatureTest::testGetFontFeaturesOpenTypeEnum() { #if HAVE_MORE_FONTS ScopedVclPtrInstance aVDev(*Application::GetDefaultDevice(), - DeviceFormat::DEFAULT, DeviceFormat::DEFAULT); + DeviceFormat::WITH_ALPHA); aVDev->SetOutputSizePixel(Size(10, 10)); OUString aFontName("Reem Kufi"); -- cgit