From 0218519537f6b77e06ae1e3020ed681b5a4f812c Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Fri, 27 Sep 2024 09:54:20 +0200 Subject: qt: Make screenNumber() a QtFrame method Don't explicitly pass a QScreen, but use the current one. Both callers set the screen just before calling the method. Change-Id: I57b3ffc4341cabc0370dda3c26d85f2f63ec9292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174032 Tested-by: Jenkins Reviewed-by: Michael Weghorn --- vcl/qt5/QtFrame.cxx | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'vcl/qt5/QtFrame.cxx') diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx index 218af25130e0..1c2e81938ecb 100644 --- a/vcl/qt5/QtFrame.cxx +++ b/vcl/qt5/QtFrame.cxx @@ -74,15 +74,6 @@ static void SvpDamageHandler(void* handle, sal_Int32 nExtentsX, sal_Int32 nExten pThis->Damage(nExtentsX, nExtentsY, nExtentsWidth, nExtentsHeight); } -namespace -{ -sal_Int32 screenNumber(QScreen* pScreen) -{ - const QList screens = QApplication::screens(); - return screens.indexOf(pScreen); -} -} - QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags nStyle, bool bUseCairo) : m_pTopLevel(nullptr) , m_bUseCairo(bUseCairo) @@ -292,6 +283,13 @@ QWindow* QtFrame::windowHandle() const QScreen* QtFrame::screen() const { return asChild()->screen(); } +sal_Int32 QtFrame::screenNumber() const +{ + QScreen* pScreen = screen(); + const QList screens = QApplication::screens(); + return screens.indexOf(pScreen); +} + bool QtFrame::GetUseDarkMode() const { #if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0) @@ -1308,7 +1306,7 @@ void QtFrame::SetScreenNumber(unsigned int nScreen) screenGeo = pScreen->availableVirtualGeometry(); pWindow->setScreen(pScreen); pWindow->setGeometry(screenGeo); - nScreen = screenNumber(pScreen); + nScreen = screenNumber(); } // setScreen by itself has no effect, explicitly move the widget to @@ -1320,7 +1318,7 @@ void QtFrame::SetScreenNumber(unsigned int nScreen) // index outta bounds, use primary screen QScreen* primaryScreen = QApplication::primaryScreen(); pWindow->setScreen(primaryScreen); - nScreen = static_cast(screenNumber(primaryScreen)); + nScreen = static_cast(screenNumber()); } maGeometry.setScreen(nScreen); -- cgit