From 458cac4674dde9c89cffb028a5d174ea61f3b81b Mon Sep 17 00:00:00 2001 From: Luboš Luňák Date: Tue, 29 Oct 2019 16:30:42 +0100 Subject: add a TODO note about Skia Vulkan surface getting recreated too often Change-Id: I558c5c161224e5ba5835fb5ec994e585c90ec14c --- vcl/skia/x11/gdiimpl.cxx | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'vcl/skia/x11') diff --git a/vcl/skia/x11/gdiimpl.cxx b/vcl/skia/x11/gdiimpl.cxx index 29119f092ac9..f4575d8af867 100644 --- a/vcl/skia/x11/gdiimpl.cxx +++ b/vcl/skia/x11/gdiimpl.cxx @@ -53,6 +53,10 @@ void X11SkiaSalGraphicsImpl::createSurface() assert(winInfo.fDisplay && winInfo.fWindow != None); winInfo.fFBConfig = nullptr; // not used winInfo.fVisualInfo = const_cast(&mX11Parent.GetVisual()); + // TODO Vulkan does not use these dimensions, instead it uses dimensions of the actual + // drawable, which may lead to repeated createSurface() calls from checkSurface() + // if the window is being resized and VCL already knows the new size but Vulkan doesn't. + // Avoid this somehow. winInfo.fWidth = GetWidth(); winInfo.fHeight = GetHeight(); destroySurface(); -- cgit