From b00d1e37c8d178f8199a45d1c9f08cae6bcef698 Mon Sep 17 00:00:00 2001
From: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Date: Fri, 13 May 2016 20:56:38 +0200
Subject: cppcheck: uninitialised members in vcl

and remove clear() on std::vector types in ctors

Change-Id: I8e239676d46e30049d4d5886a5b8de99cadd3f45
Reviewed-on: https://gerrit.libreoffice.org/24983
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
---
 vcl/source/fontsubset/cff.cxx | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

(limited to 'vcl/source/fontsubset/cff.cxx')

diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx
index ac3bf78bb098..74725eab8990 100644
--- a/vcl/source/fontsubset/cff.cxx
+++ b/vcl/source/fontsubset/cff.cxx
@@ -424,8 +424,11 @@ CffSubsetterContext::CffSubsetterContext( const U8* pBasePtr, int nBaseLen)
     , mpCharStringOps(nullptr)
     , mpCharStringEscs(nullptr)
     , mnStackIdx(0)
+    , mnValStack{}
+    , mnTransVals{}
     , mnHintSize(0)
     , mnHorzHintSize(0)
+    , mnHintStack{}
     , maCharWidth(-1)
 {
 //  setCharStringType( 1);
@@ -1406,12 +1409,6 @@ CffLocal::CffLocal()
 ,   mnLangGroup( 0)
 ,   mbForceBold( false)
 {
-    maStemSnapH.clear();
-    maStemSnapV.clear();
-    maBlueValues.clear();
-    maOtherBlues.clear();
-    maFamilyBlues.clear();
-    maFamilyOtherBlues.clear();
 }
 
 CffGlobal::CffGlobal()
@@ -1434,8 +1431,6 @@ CffGlobal::CffGlobal()
 ,   mnFullNameSID( 0)
 ,   mnFamilyNameSID( 0)
 {
-    maFontBBox.clear();
-    // TODO; maFontMatrix.clear();
 }
 
 bool CffSubsetterContext::initialCffRead()
@@ -1734,6 +1729,7 @@ public:
 Type1Emitter::Type1Emitter( FILE* pOutFile, bool bPfbSubset)
 :   mpFileOut( pOutFile)
 ,   mbCloseOutfile( false)
+,   maBuffer{}
 ,   mnEECryptR( 55665)  // default eexec seed, TODO: mnEECryptSeed
 ,   mpPtr( maBuffer)
 ,   mbPfbSubset( bPfbSubset)
-- 
cgit