From b55ee51befef86a32a996b4dc55014c21b45ef5c Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sat, 1 Jun 2019 21:53:32 +0100 Subject: no direct ModelessDialog instantiation left MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: If31cf3c02ab714f45ebbc0139e0e77102b5eb2ba Reviewed-on: https://gerrit.libreoffice.org/73325 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- vcl/README.lifecycle | 4 ++-- vcl/qa/cppunit/lifecycle.cxx | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'vcl') diff --git a/vcl/README.lifecycle b/vcl/README.lifecycle index dc6286210780..d9d186425b64 100644 --- a/vcl/README.lifecycle +++ b/vcl/README.lifecycle @@ -308,11 +308,11 @@ ways and often both. Window that has already been destroyed. This can easily happen via this sort of pattern: - ModelessDialog *pDlg = VclPtr(nullptr /* parent */); + ModalDialog *pDlg = VclPtr(nullptr /* parent */); // by here the pDlg quite probably points to free'd memory... It is necessary in these cases to ensure that the *pDlg is - a VclPtr instead. + a VclPtr instead. ** It crashes with some invalid memory #2... diff --git a/vcl/qa/cppunit/lifecycle.cxx b/vcl/qa/cppunit/lifecycle.cxx index 118114736c6a..98db6704e28a 100644 --- a/vcl/qa/cppunit/lifecycle.cxx +++ b/vcl/qa/cppunit/lifecycle.cxx @@ -299,7 +299,6 @@ void LifecycleTest::testLeakage() aObjects.push_back(LeakTestObject::Create(xVBox)); } - aObjects.push_back(LeakTestObject::Create(xParent, "PrintProgressDialog", "vcl/ui/printprogressdialog.ui")); aObjects.push_back(LeakTestObject::Create(xParent, "PrintProgressDialog", "vcl/ui/printprogressdialog.ui")); xParent.clear(); -- cgit