From f09d88e8f8f599938e78adf72fc96cedb261afef Mon Sep 17 00:00:00 2001 From: Jens Carl Date: Sun, 17 Nov 2019 10:55:39 -0800 Subject: Fix 'is' operator for comparison MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ifabe22e4ae3b9e1d3bfd5a663f39500e381cfa6e Reviewed-on: https://gerrit.libreoffice.org/83034 Tested-by: Jenkins Reviewed-by: Xisco Faulí --- wizards/com/sun/star/wizards/common/FileAccess.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'wizards') diff --git a/wizards/com/sun/star/wizards/common/FileAccess.py b/wizards/com/sun/star/wizards/common/FileAccess.py index 2740b7aa3c3e..c58f6d4b424c 100644 --- a/wizards/com/sun/star/wizards/common/FileAccess.py +++ b/wizards/com/sun/star/wizards/common/FileAccess.py @@ -129,7 +129,7 @@ class FileAccess(object): def getPath(self, parentURL, childURL): string = "" - if childURL is not None and childURL is not "": + if childURL is not None and childURL != "": string = "/" + childURL return self.filenameConverter.getSystemPathFromFileURL( parentURL + string) -- cgit