From 0fb5ca6cc9cc55a4436a36c533461769b1fc8526 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 5 Jul 2018 14:29:11 +0200 Subject: tdf#79877 perf loading docx file, writerfilter/ improvements this improves load time by 20%. We switch from shared_ptr to tools::SvRef to manage the objects I noticed some double inheritance like this: DomainMapper LoggedProperties Properties SvRefBase LoggedTable Table SvRefBase so to be safe I made all the ref-count-base-class inheritance virtual. Change-Id: Ia3de9733f5c6966e8171f43d083dcc087040b8cd Reviewed-on: https://gerrit.libreoffice.org/57022 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- writerfilter/source/dmapper/FontTable.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'writerfilter/source/dmapper/FontTable.cxx') diff --git a/writerfilter/source/dmapper/FontTable.cxx b/writerfilter/source/dmapper/FontTable.cxx index 70b425e91fae..67224202b886 100644 --- a/writerfilter/source/dmapper/FontTable.cxx +++ b/writerfilter/source/dmapper/FontTable.cxx @@ -159,11 +159,11 @@ void FontTable::lcl_entry(int /*pos*/, writerfilter::Reference::Poin { //create a new font entry SAL_WARN_IF( m_pImpl->pCurrentEntry, "writerfilter.dmapper", "current entry has to be NULL here" ); - m_pImpl->pCurrentEntry.reset(new FontEntry); + m_pImpl->pCurrentEntry = new FontEntry; ref->resolve(*this); //append it to the table m_pImpl->aFontEntries.push_back( m_pImpl->pCurrentEntry ); - m_pImpl->pCurrentEntry.reset(); + m_pImpl->pCurrentEntry.clear(); } void FontTable::lcl_startSectionGroup() -- cgit