From 2f5868c4309d49ad495e0763b5b57d1f7f98e377 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 9 Mar 2018 13:59:52 +0200 Subject: loplugin:redundantfcast look for redundant copies in return statements Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins Reviewed-by: Noel Grandin --- xmlhelp/source/cxxhelp/provider/provider.cxx | 6 ++---- xmlhelp/source/cxxhelp/provider/resultsetbase.hxx | 2 +- xmlhelp/source/treeview/tvfactory.cxx | 5 ++--- 3 files changed, 5 insertions(+), 8 deletions(-) (limited to 'xmlhelp') diff --git a/xmlhelp/source/cxxhelp/provider/provider.cxx b/xmlhelp/source/cxxhelp/provider/provider.cxx index 78912d06b0c5..4c4532569848 100644 --- a/xmlhelp/source/cxxhelp/provider/provider.cxx +++ b/xmlhelp/source/cxxhelp/provider/provider.cxx @@ -152,13 +152,11 @@ css::uno::Reference< css::lang::XSingleServiceFactory > ContentProvider::createServiceFactory( const css::uno::Reference< css::lang::XMultiServiceFactory >& rxServiceMgr ) { - return css::uno::Reference< - css::lang::XSingleServiceFactory >( - cppu::createOneInstanceFactory( + return cppu::createOneInstanceFactory( rxServiceMgr, ContentProvider::getImplementationName_Static(), ContentProvider_CreateInstance, - ContentProvider::getSupportedServiceNames_Static() ) ); + ContentProvider::getSupportedServiceNames_Static() ); } // XContentProvider methods. diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx index 9c1a016030dd..d684db8f5b66 100644 --- a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx +++ b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx @@ -133,7 +133,7 @@ namespace chelp { if( 0 <= m_nRow && sal::static_int_cast( m_nRow ) < m_aItems.size() ) return m_aItems[m_nRow]->getInt( columnIndex ); else - return sal_Int32( 0 ); + return 0; } virtual sal_Int64 SAL_CALL diff --git a/xmlhelp/source/treeview/tvfactory.cxx b/xmlhelp/source/treeview/tvfactory.cxx index 9edb304cd791..30fcd22bff43 100644 --- a/xmlhelp/source/treeview/tvfactory.cxx +++ b/xmlhelp/source/treeview/tvfactory.cxx @@ -142,12 +142,11 @@ Reference< XSingleServiceFactory > TVFactory::createServiceFactory( const Reference< XMultiServiceFactory >& rxServiceMgr ) { - return Reference< XSingleServiceFactory > ( - cppu::createSingleFactory( + return cppu::createSingleFactory( rxServiceMgr, TVFactory::getImplementationName_static(), TVFactory::CreateInstance, - TVFactory::getSupportedServiceNames_static() ) ); + TVFactory::getSupportedServiceNames_static() ); } Reference< XInterface > SAL_CALL -- cgit