From fa47856e51c2c1102b3df0adead2c0701bd4cbde Mon Sep 17 00:00:00 2001 From: Michael Stahl Date: Tue, 10 Apr 2018 10:26:44 +0200 Subject: xmloff: fix leak in XMLPropertySetMapperEntry_Impl The XMLNamedBoolPropertyHdl should be owned by OControlPropertyHandlerFactory like all the other handlers created in that function. Thanks to Julien Nabet for pointing out the problem. Change-Id: Id474b2fdb84ca74f686d0c888fbedbee623c31bb Reviewed-on: https://gerrit.libreoffice.org/52666 Tested-by: Jenkins Reviewed-by: Michael Stahl --- xmloff/source/forms/controlpropertyhdl.cxx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'xmloff/source/forms') diff --git a/xmloff/source/forms/controlpropertyhdl.cxx b/xmloff/source/forms/controlpropertyhdl.cxx index ba5a27f8661d..839789167e9e 100644 --- a/xmloff/source/forms/controlpropertyhdl.cxx +++ b/xmloff/source/forms/controlpropertyhdl.cxx @@ -99,9 +99,13 @@ namespace xmloff pHandler = m_pFontReliefHandler.get(); break; case XML_TYPE_TEXT_LINE_MODE: - pHandler = new XMLNamedBoolPropertyHdl( - ::xmloff::token::XML_SKIP_WHITE_SPACE, - ::xmloff::token::XML_CONTINUOUS); + if (!m_pTextLineModeHandler) + { + m_pTextLineModeHandler = o3tl::make_unique( + ::xmloff::token::XML_SKIP_WHITE_SPACE, + ::xmloff::token::XML_CONTINUOUS); + } + pHandler = m_pTextLineModeHandler.get(); break; } -- cgit