From 17a2c9e8e2361de27013a25e51f3a3ca729f1b31 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 5 Jun 2017 08:34:22 +0200 Subject: clang-tidy performance-unnecessary-value-param Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins Reviewed-by: Noel Grandin --- xmloff/inc/animationimport.hxx | 2 +- xmloff/source/draw/animationimport.cxx | 2 +- xmloff/source/draw/shapeimport.cxx | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) (limited to 'xmloff') diff --git a/xmloff/inc/animationimport.hxx b/xmloff/inc/animationimport.hxx index a6e3821b89ac..03abc23a6f9b 100644 --- a/xmloff/inc/animationimport.hxx +++ b/xmloff/inc/animationimport.hxx @@ -47,7 +47,7 @@ public: sal_uInt16 nPrfx, const OUString& rLocalName, const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList, - std::shared_ptr pImpl = nullptr ); + const std::shared_ptr& pImpl = nullptr ); virtual void StartElement( const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList ) override; diff --git a/xmloff/source/draw/animationimport.cxx b/xmloff/source/draw/animationimport.cxx index d32ecdbd8c1d..704ab904b17b 100644 --- a/xmloff/source/draw/animationimport.cxx +++ b/xmloff/source/draw/animationimport.cxx @@ -627,7 +627,7 @@ AnimationNodeContext::AnimationNodeContext( const Reference< XAnimationNode >& xParentNode, SvXMLImport& rImport, sal_uInt16 nPrfx, const OUString& rLocalName, const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList, - std::shared_ptr pHelper ) + const std::shared_ptr& pHelper ) : SvXMLImportContext(rImport, nPrfx, rLocalName), mpHelper( pHelper ), mbRootContext( !pHelper ) diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx index 709b703ca6b0..17682d8ba61c 100644 --- a/xmloff/source/draw/shapeimport.cxx +++ b/xmloff/source/draw/shapeimport.cxx @@ -24,6 +24,7 @@ #include #include +#include #include #include @@ -721,7 +722,7 @@ private: }; ShapeSortContext::ShapeSortContext( uno::Reference< drawing::XShapes >& rShapes, std::shared_ptr pParentContext ) -: mxShapes( rShapes ), mnCurrentZ( 0 ), mpParentContext( pParentContext ) +: mxShapes( rShapes ), mnCurrentZ( 0 ), mpParentContext( std::move(pParentContext) ) { } -- cgit