From 6e72f0251bb8767942edf74f612547c12ca0cdf1 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Jul 2016 08:21:27 +0200 Subject: new loplugin unnecessary override Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann Tested-by: Stephan Bergmann --- xmloff/CppunitTest_xmloff_uxmloff.mk | 1 + xmloff/source/draw/ximp3dobject.cxx | 7 ------- xmloff/source/draw/ximp3dobject.hxx | 1 - xmloff/source/draw/ximplink.cxx | 10 --------- xmloff/source/draw/ximplink.hxx | 2 -- xmloff/source/draw/ximpnote.cxx | 5 ----- xmloff/source/draw/ximpnote.hxx | 1 - xmloff/source/transform/MergeElemTContext.cxx | 29 --------------------------- 8 files changed, 1 insertion(+), 55 deletions(-) (limited to 'xmloff') diff --git a/xmloff/CppunitTest_xmloff_uxmloff.mk b/xmloff/CppunitTest_xmloff_uxmloff.mk index cf2b0c693adf..7e517229b47f 100644 --- a/xmloff/CppunitTest_xmloff_uxmloff.mk +++ b/xmloff/CppunitTest_xmloff_uxmloff.mk @@ -44,6 +44,7 @@ $(eval $(call gb_CppunitTest_use_libraries,xmloff_uxmloff, \ svl \ test \ tl \ + unotest \ utl \ vcl \ $(gb_UWINAPI) \ diff --git a/xmloff/source/draw/ximp3dobject.cxx b/xmloff/source/draw/ximp3dobject.cxx index 557d104bdb31..2229a56239ca 100644 --- a/xmloff/source/draw/ximp3dobject.cxx +++ b/xmloff/source/draw/ximp3dobject.cxx @@ -95,13 +95,6 @@ void SdXML3DObjectContext::StartElement(const uno::Reference< xml::sax::XAttribu } } -void SdXML3DObjectContext::EndElement() -{ - // call parent - SdXMLShapeContext::EndElement(); -} - - SdXML3DCubeObjectShapeContext::SdXML3DCubeObjectShapeContext( SvXMLImport& rImport, sal_uInt16 nPrfx, diff --git a/xmloff/source/draw/ximp3dobject.hxx b/xmloff/source/draw/ximp3dobject.hxx index b66dbaece749..cf4b13669c1a 100644 --- a/xmloff/source/draw/ximp3dobject.hxx +++ b/xmloff/source/draw/ximp3dobject.hxx @@ -49,7 +49,6 @@ public: virtual ~SdXML3DObjectContext(); virtual void StartElement(const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList) override; - virtual void EndElement() override; }; // dr3d:3dcube context diff --git a/xmloff/source/draw/ximplink.cxx b/xmloff/source/draw/ximplink.cxx index 18349cf43936..edbc4bb30d42 100644 --- a/xmloff/source/draw/ximplink.cxx +++ b/xmloff/source/draw/ximplink.cxx @@ -65,14 +65,4 @@ SvXMLImportContext* SdXMLShapeLinkContext::CreateChildContext( sal_uInt16 nPrefi } -void SdXMLShapeLinkContext::StartElement(const uno::Reference< xml::sax::XAttributeList>& xAttr ) -{ - SvXMLImportContext::StartElement( xAttr ); -} - -void SdXMLShapeLinkContext::EndElement() -{ - SvXMLImportContext::EndElement(); -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/draw/ximplink.hxx b/xmloff/source/draw/ximplink.hxx index fac6b99382be..187cda328f34 100644 --- a/xmloff/source/draw/ximplink.hxx +++ b/xmloff/source/draw/ximplink.hxx @@ -47,8 +47,6 @@ public: virtual SvXMLImportContext *CreateChildContext( sal_uInt16 nPrefix, const OUString& rLocalName, const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList ) override; - virtual void StartElement(const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList) override; - virtual void EndElement() override; }; #endif // INCLUDED_XMLOFF_SOURCE_DRAW_XIMPLINK_HXX diff --git a/xmloff/source/draw/ximpnote.cxx b/xmloff/source/draw/ximpnote.cxx index 23272f3e6730..4f711bb042ce 100644 --- a/xmloff/source/draw/ximpnote.cxx +++ b/xmloff/source/draw/ximpnote.cxx @@ -100,9 +100,4 @@ SvXMLImportContext *SdXMLNotesContext::CreateChildContext( sal_uInt16 nPrefix, return SdXMLGenericPageContext::CreateChildContext(nPrefix, rLocalName, xAttrList); } -void SdXMLNotesContext::EndElement() -{ - SdXMLGenericPageContext::EndElement(); -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/draw/ximpnote.hxx b/xmloff/source/draw/ximpnote.hxx index a27e33e52907..a53a5c70084c 100644 --- a/xmloff/source/draw/ximpnote.hxx +++ b/xmloff/source/draw/ximpnote.hxx @@ -42,7 +42,6 @@ public: virtual SvXMLImportContext *CreateChildContext( sal_uInt16 nPrefix, const OUString& rLocalName, const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList ) override; - virtual void EndElement() override; }; #endif // INCLUDED_XMLOFF_SOURCE_DRAW_XIMPNOTE_HXX diff --git a/xmloff/source/transform/MergeElemTContext.cxx b/xmloff/source/transform/MergeElemTContext.cxx index f35fde9c4dfe..6b3df5fa947e 100644 --- a/xmloff/source/transform/MergeElemTContext.cxx +++ b/xmloff/source/transform/MergeElemTContext.cxx @@ -45,20 +45,6 @@ public: const OUString& rLocalName, const OUString& rQName, const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList ) override; - - // StartElement is called after a context has been constructed and - // before a elements context is parsed. It may be used for actions that - // require virtual methods. The default is to do nothing. - virtual void StartElement( const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList ) override; - - // EndElement is called before a context will be destructed, but - // after a elements context has been parsed. It may be used for actions - // that require virtual methods. The default is to do nothing. - virtual void EndElement() override; - - // This method is called for all characters that are contained in the - // current element. The default is to ignore them. - virtual void Characters( const OUString& rChars ) override; }; XMLParagraphTransformerContext::XMLParagraphTransformerContext( @@ -82,21 +68,6 @@ rtl::Reference XMLParagraphTransformerContext::CreateChil rQName, true ); } -void XMLParagraphTransformerContext::StartElement( const Reference< XAttributeList >& rAttrList ) -{ - XMLTransformerContext::StartElement( rAttrList ); -} - -void XMLParagraphTransformerContext::EndElement() -{ - XMLTransformerContext::EndElement(); -} - -void XMLParagraphTransformerContext::Characters( const OUString& rChars ) -{ - XMLTransformerContext::Characters( rChars ); -} - class XMLPersTextContentRNGTransformTContext : public XMLPersTextContentTContext { public: -- cgit